Horton

RE: Remove "FROM" in "DELETE FROM" when using tab-completion

tanghy.fnst@fujitsu.com <tanghy.fnst@fujitsu.com>

View thread View on postgr.es
From: "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>
To: Michael Paquier <michael@paquier.xyz>, Dilip Kumar <dilipbalaut@gmail.com>
Cc: Julien Rouhaud <rjuju123@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2021-05-11T07:30:47Z
Lists: pgsql-hackers 
On Tuesday, May 11, 2021 2:53 PM, Michael Paquier <michael@paquier.xyz> wrote
>    else if (TailMatches("DELETE", "FROM", MatchAny))
>            COMPLETE_WITH("USING", "WHERE");
>-   /* XXX: implement tab completion for DELETE ... USING */
>
>Why are you removing that?  This sentence is still true, no?

IIRC, XXX in comment is used to flag something that is bogus but works.
When the sentence introduced here in f5ab0a14, the fix for "DELETE ... USING" is not as good as it is now.(I guess that's why the comment was added). And for now, IMHO, we can remove the comment directly. 

If my understanding here is wrong, please let me know and that would be great to learn more about PG.

Regards,
Tang

Commits

  1. Make saner the tab completion of INSERT and DELETE in psql

  2. psql tab completion improvements, from Greg Sabino Mullane: