RE: fix a comment

wangyukun@fujitsu.com <wangyukun@fujitsu.com>

From: "wangyukun@fujitsu.com" <wangyukun@fujitsu.com>
To: Amul Sul <sulamul@gmail.com>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2021-04-23T07:03:40Z
Lists: pgsql-hackers

Attachments

Hi, Amul

Thank you for reviewing.

> How about simply removing these numbering?

Agree. Please see the v2 patch which delete the number in comment.

Best wishes
Yukun Wang

-----Original Message-----
From: Amul Sul <sulamul@gmail.com> 
Sent: Friday, April 23, 2021 3:51 PM
To: Wang, Yukun/王 俞坤 <wangyukun@fujitsu.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: fix a comment

On Fri, Apr 23, 2021 at 12:12 PM wangyukun@fujitsu.com <wangyukun@fujitsu.com> wrote:
>
> Hi, Hackers:
>
> In function ExecGetTriggerResultRel, we can see comments:
>
> > /* First, search through the query result relations */ ...
> > /*
> > * Third, search through the result relations that were created 
> > during
> > * tuple routing, if any.
> > */
>
> But the 'Second' was deleted since commit 1375422c78.
>
> Update the 'Third' to 'Second', please see the attachment.
>
> Thoughts?
>

Well yes, looks good to me.

How about simply removing these numbering?

Regards,
Amul

Commits

  1. Fix come comments in execMain.c

  2. Create ResultRelInfos later in InitPlan, index them by RT index.