RE: bogus: logical replication rows/cols combinations
Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com>
From: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>
To: Justin Pryzby <pryzby@telsasoft.com>, Amit Kapila <amit.kapila16@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Tomas Vondra <tomas.vondra@enterprisedb.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2022-05-27T07:34:32Z
Lists: pgsql-hackers
Attachments
- 0001-language-fixes-on-HEAD-from-Justin.patch (application/octet-stream) patch 0001
- v6-0001-Prohibit-combining-publications-with-different-co.patch (application/octet-stream) patch v6-0001
On Friday, May 27, 2022 1:54 PM Justin Pryzby <pryzby@telsasoft.com> wrote: > > On Fri, May 27, 2022 at 11:17:00AM +0530, Amit Kapila wrote: > > On Tue, May 24, 2022 at 11:03 AM houzj.fnst@fujitsu.com > <houzj.fnst@fujitsu.com> wrote: > > > > > > On Friday, May 20, 2022 11:06 AM Amit Kapila <amit.kapila16@gmail.com> > wrote: > > > > > > Thanks for pointing it out. Here is the new version patch which add this > version check. > > > > I have added/edited a few comments and ran pgindent. The attached > > looks good to me. I'll push this early next week unless there are more > > comments/suggestions. > > A minor doc review. > Note that I also sent some doc comments at > 20220519120724.GO19626@telsasoft.com. > > + lists among publications in which case <command>ALTER > PUBLICATION</command> > + command will be successful but later the WalSender in publisher > + or the > > COMMA in which > > remove "command" ? > > s/in publisher/on the publisher/ > > + Subscription having several publications in which the same table has been > + published with different column lists is not supported. > > Either "Subscriptions having .. are not supported"; or, "A subscription having .. > is not supported". Thanks for the comments. Here is the new version patch set which fixes these. Best regards, Hou zj
Commits
-
Prohibit combining publications with different column lists.
- fd0b9dcebda7 15.0 landed
-
Extend pg_publication_tables to display column list and row filter.
- 0ff20288e1cb 15.0 landed
-
Remove dynamic_shared_memory_type=none
- bcbd940806a2 12.0 cited