RE: Skipping logical replication transactions on subscriber side

Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com>

From: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>

To: Masahiko Sawada <sawada.mshk@gmail.com>

Cc: Greg Nancarrow <gregn4422@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>, "osumi.takamichi@fujitsu.com" <osumi.takamichi@fujitsu.com>, Alexey Lesovsky <lesovsky@gmail.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, vignesh C <vignesh21@gmail.com>

Date: 2021-11-18T03:52:23Z

Lists: pgsql-hackers

On Tuesday, November 16, 2021 2:31 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> Right. I've fixed this issue and attached an updated patch.
> 
Hi,

I have few comments for the testcases.

1)

+my $appname = 'tap_sub';
+$node_subscriber->safe_psql(
+    'postgres',
+    "CREATE SUBSCRIPTION tap_sub CONNECTION '$publisher_connstr application_name=$appname' PUBLICATION tap_pub WITH (streaming = off, two_phase = on);");
+my $appname_streaming = 'tap_sub_streaming';
+$node_subscriber->safe_psql(
+    'postgres',
+    "CREATE SUBSCRIPTION tap_sub_streaming CONNECTION '$publisher_connstr application_name=$appname_streaming' PUBLICATION tap_pub_streaming WITH (streaming = on, two_phase = on);");
+

I think we can remove the 'application_name=$appname', so that the command
could be shorter. 

2)
+...(streaming = on, two_phase = on);");
Besides, is there some reasons to set two_phase to ? If so,
It might be better to add some comments about it.


3)
+CREATE PUBLICATION tap_pub_streaming FOR TABLE test_tab_streaming;
+]);
+

It seems there's no tests to use the table test_tab_streaming. I guess this
table is used to test streaming change error, maybe we can add some tests for
it ?

Best regards,
Hou zj

Commits

Test ALIGNOF_DOUBLE==4 compatibility under ALIGNOF_DOUBLE==8.
- c1da0acbb06e 15.0 landed
Reorder subskiplsn in pg_subscription to avoid alignment issues.
- 79b716cfb7a1 15.0 landed
Add ALTER SUBSCRIPTION ... SKIP.
- 208c5d65bbd6 15.0 landed
Optionally disable subscriptions on error.
- 705e20f8550c 15.0 cited
Update docs of logical replication for commit 8d74fc96db.
- 85c61ba8920b 15.0 landed
Respect permissions within logical replication.
- a2ab9c06ea15 15.0 cited
Fix regression test failure caused by commit 8d74fc96db.
- 41e66fee0516 15.0 landed
Add a view to show the stats of subscription workers.
- 8d74fc96db5f 15.0 landed
Add logical change details to logical replication worker errcontext.
- abc0910e2e0a 15.0 landed
Rename LOGICAL_REP_MSG_STREAM_END to LOGICAL_REP_MSG_STREAM_STOP.
- 4cd7a1896871 15.0 landed
Fix typo in protocol.sgml.
- e1915646658d 14.0 landed
- 0ac1aee0d7d8 15.0 landed
Remove unused argument in apply_handle_commit_internal().
- f4b939f1a372 14.0 landed
- 16bd4becee32 15.0 landed
Fix replication of in-progress transactions in tablesync worker.
- 0926e96c4934 14.0 cited
Reorder pg_sequence columns to avoid alignment issue
- f3b421da5f4a 10.0 cited