Thread

Commits

  1. Fix typo in comments.

  1. Fix typo in comments

    Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com> — 2021-09-02T11:54:15Z

    Hi,
    
    When reviewing other patches, I noticed two typos:
    
    1.
    src/backend/parser/gram.y
    ALTER TABLE <name> ALTER [COLUMN] <colname> RESET ( column_parameter = value [, ... ] )
    
    RESET cannot specify value.
    
    2.
    src/backend/utils/adt/xid8funcs.c
    * Same as pg_current_xact_if_assigned() but doesn't assign a new xid if there
    
    pg_current_xact_if_assigned() should be pg_current_xact_id()
    
    Best regards,
    Hou zhijie
    
    
  2. Re: Fix typo in comments

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2021-09-02T12:47:35Z

    
    On 2021/09/02 20:54, houzj.fnst@fujitsu.com wrote:
    > Hi,
    > 
    > When reviewing other patches, I noticed two typos:
    
    Thanks! Both fixes look good to me.
    Barring any objection, I will commit the patch.
    
    Regards,
    
    -- 
    Fujii Masao
    Advanced Computing Technology Center
    Research and Development Headquarters
    NTT DATA CORPORATION
    
    
    
    
  3. Re: Fix typo in comments

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2021-09-06T08:10:16Z

    
    On 2021/09/02 21:47, Fujii Masao wrote:
    > 
    > 
    > On 2021/09/02 20:54, houzj.fnst@fujitsu.com wrote:
    >> Hi,
    >>
    >> When reviewing other patches, I noticed two typos:
    > 
    > Thanks! Both fixes look good to me.
    > Barring any objection, I will commit the patch.
    
    Pushed. Thanks!
    
    Regards,
    
    -- 
    Fujii Masao
    Advanced Computing Technology Center
    Research and Development Headquarters
    NTT DATA CORPORATION