Horton

RE: BUG #18055: logical decoding core on AllocateSnapshotBuilder()

Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com>

View thread
From: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>, "ocean_li_996@163.com" <ocean_li_996@163.com>, "pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>, Andres Freund <andres@anarazel.de>
Date: 2023-09-07T12:10:52Z
Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix uninitialized access to InitialRunningXacts during decoding after ERROR.

Attachments

On Tuesday, September 5, 2023 7:31 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> 
> On Fri, Aug 25, 2023 at 9:36 AM Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com>
> wrote:
> >
> > On Wednesday, August 23, 2023 4:47 PM Amit Kapila
> <amit.kapila16@gmail.com> wrote:
> > >
> > > On Mon, Aug 21, 2023 at 11:57 PM Andres Freund <andres@anarazel.de>
> > > wrote:
> > > >
> > > > -1. This makes things global concerns that shouldn't be.
> > > >
> > > > If we really need something to clean this up, I'd look at
> > > > MemoryContextRegisterResetCallback().
> > > >
> > >
> > > +1. This sounds like a better idea.
> >
> > Here is a small patch based on this idea.
> > I registered the callback under snapshot builder context and the
> > callback will reset the variables.
> >
> 
> LGTM. Unless Andres or Sawada-San thinks otherwise, I would like to proceed
> with this fix.

Thanks, attach the patches for all support branches. I have confirmed that they can
pass the regression test and fix the issue.

Best Regards,
Hou zj