Horton

RE: row filtering for logical replication

Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com>

View thread
From: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Peter Smith <smithpb2250@gmail.com>, Euler Taveira <euler@eulerto.com>, Greg Nancarrow <gregn4422@gmail.com>, vignesh C <vignesh21@gmail.com>, Ajin Cherian <itsajin@gmail.com>, "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>, Dilip Kumar <dilipbalaut@gmail.com>, Rahila Syed <rahilasyed90@gmail.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Önder Kalacı <onderkalaci@gmail.com>, japin <japinli@hotmail.com>, Michael Paquier <michael@paquier.xyz>, David Steele <david@pgmasters.net>, Craig Ringer <craig@2ndquadrant.com>, Amit Langote <amitlangote09@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-01-21T09:39:33Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Release cache tuple when no longer needed

  2. Add some additional tests for row filters in logical replication.

  3. Fix one of the tests introduced in commit 52e4f0cd47.

  4. Allow specifying row filters for logical replication of tables.

  5. Move scanint8() to numutils.c

  6. Replace Test::More plans with done_testing

  7. Reduce relcache access in WAL sender streaming logical changes

  8. Small cleanups related to PUBLICATION framework code

  9. Add a view to show the stats of subscription workers.

  10. Allow publishing the tables of schema.

  11. Doc: improve documentation of CREATE/ALTER SUBSCRIPTION.

  12. Add PublicationTable and PublicationRelInfo structs

  13. Remove unused argument "txn" in maybe_send_schema().

  14. Add prepare API support for streaming transactions in logical replication.

  15. Unify PostgresNode's new() and get_new_node() methods

  16. Use l*_node() family of functions where appropriate

  17. Add support for prepared transactions to built-in logical replication.

  18. Restore the portal-level snapshot after procedure COMMIT/ROLLBACK.

  19. Rename a parse node to be more general

  20. Remove unused column atttypmod from initial tablesync query

  21. SEARCH and CYCLE clauses

Attachments

On Thursday, January 20, 2022 8:53 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> 
> On Thu, Jan 20, 2022 at 5:03 PM tanghy.fnst@fujitsu.com
> <tanghy.fnst@fujitsu.com> wrote:
> >
> > On Thu, Jan 20, 2022 9:13 AM houzj.fnst@fujitsu.com
> <houzj.fnst@fujitsu.com> wrote:
> > > Attach the V68 patch set which addressed the above comments and
> changes.
> > > The version patch also fix the error message mentioned by Greg[1]
> > >
> >
> > I saw a problem about this patch, which is related to Replica Identity check.
> >
> > For example:
> > -- publisher --
> > create table tbl (a int);
> > create publication pub for table tbl where (a>10) with (publish='delete');
> > insert into tbl values (1);
> > update tbl set a=a+1;
> >
> > postgres=# update tbl set a=a+1;
> > ERROR:  cannot update table "tbl"
> > DETAIL:  Column "a" used in the publication WHERE expression is not part of
> the replica identity.
> >
> > I think it shouldn't report the error because the publication didn't publish
> UPDATES.
> >
> 
> Right, I also don't see any reason why an error should be thrown in
> this case. The problem here is that the patch doesn't have any
> correspondence between the pubaction and RI column validation for a
> particular publication. I think we need to do that and cache that
> information unless the publication publishes both updates and deletes
> in which case it is okay to directly return invalid column in row
> filter as we are doing now.

Attach the v69 patch set which fix this.
The new version patch also addressed comments from Peter[1] and Amit[2].
I also added some testcases about partitioned table in the 027_row_filter.pl.

Note that the comments from Alvaro[3] haven't been addressed
because the discussion is still going on, I will address those
comments soon.

[1] https://www.postgresql.org/message-id/CAHut%2BPtUiaYaihtw6_SmqbwEBXtw6ryc7F%3DVEQkK%3D7HW18dGVg%40mail.gmail.com
[2] https://www.postgresql.org/message-id/CAA4eK1JzKYBC5Aos9QncZ%2BJksMLmZjpCcDmBJZQ1qC74AYggNg%40mail.gmail.com
[3] https://www.postgresql.org/message-id/202201201313.zaceiqi4qb6h%40alvherre.pgsql

Best regards,
Hou zj