Horton

RE: row filtering for logical replication

Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com>

View thread
From: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>
To: Peter Smith <smithpb2250@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, vignesh C <vignesh21@gmail.com>, Greg Nancarrow <gregn4422@gmail.com>, "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>, Ajin Cherian <itsajin@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, Euler Taveira <euler@eulerto.com>, Rahila Syed <rahilasyed90@gmail.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Önder Kalacı <onderkalaci@gmail.com>, japin <japinli@hotmail.com>, Michael Paquier <michael@paquier.xyz>, David Steele <david@pgmasters.net>, Craig Ringer <craig@2ndquadrant.com>, Amit Langote <amitlangote09@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-12-02T03:59:07Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Release cache tuple when no longer needed

  2. Add some additional tests for row filters in logical replication.

  3. Fix one of the tests introduced in commit 52e4f0cd47.

  4. Allow specifying row filters for logical replication of tables.

  5. Move scanint8() to numutils.c

  6. Replace Test::More plans with done_testing

  7. Reduce relcache access in WAL sender streaming logical changes

  8. Small cleanups related to PUBLICATION framework code

  9. Add a view to show the stats of subscription workers.

  10. Allow publishing the tables of schema.

  11. Doc: improve documentation of CREATE/ALTER SUBSCRIPTION.

  12. Add PublicationTable and PublicationRelInfo structs

  13. Remove unused argument "txn" in maybe_send_schema().

  14. Add prepare API support for streaming transactions in logical replication.

  15. Unify PostgresNode's new() and get_new_node() methods

  16. Use l*_node() family of functions where appropriate

  17. Add support for prepared transactions to built-in logical replication.

  18. Restore the portal-level snapshot after procedure COMMIT/ROLLBACK.

  19. Rename a parse node to be more general

  20. Remove unused column atttypmod from initial tablesync query

  21. SEARCH and CYCLE clauses

Attachments

On Thur, Dec 2, 2021 5:21 AM Peter Smith <smithpb2250@gmail.com> wrote:
> PSA the v44* set of patches.
> 
> The following review comments are addressed:
> 
> v44-0001 main patch
> - Renamed the TAP test 026->027 due to clash caused by recent commit [1]
> - Refactored table_close [Houz 23/11] #2
> - Alter compare where clauses [Amit 24/11] #0
> - PG docs CREATE SUBSCRIPTION [Tang 30/11] #2
> - PG docs CREATE PUBLICATION [Vignesh 30/11] #1, #4, [Tang 30/11] #1, [Tomas
> 23/9] #2
> 
> v44-0002 validation walker
> - Add NullTest support [Peter 18/11]
> - Update comments [Amit 24/11] #3
> - Disallow user-defined types [Amit 24/11] #4
> - Errmsg - skipped because handled by top-up [Vignesh 23/11] #2
> - Removed #if 0 [Vignesh 30/11] #2
> 
> v44-0003 new/old tuple
> - NA
> 
> v44-0004 tab-complete and pgdump
> - Handle table-list commas better [Vignesh 23/11] #2
> 
> v44-0005 top-up patch for validation
> - (This patch will be added again later)

Attach the v44-0005 top-up patch.
This version addressed all the comments received so far,
mainly including the following changes:
1) rename rfcol_valid_for_replica to rfcol_valid
2) Remove the struct PublicationInfo and add the rfcol_valid flag directly in relation
3) report the invalid column number in the error message.
4) Rename some function to match the usage.
5) Fix some typos and add some code comments.
6) Fix a miss in testcase.

Best regards,
Hou zj