Horton

RE: [BUG] wrong refresh when ALTER SUBSCRIPTION ADD/DROP PUBLICATION

Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com>

View thread View on postgr.es
From: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Japin Li <japinli@hotmail.com>
Date: 2021-08-24T01:01:51Z
Lists: pgsql-hackers

Attachments


> -----Original Message-----
> From: Masahiko Sawada <sawada.mshk@gmail.com>
> Sent: Tuesday, August 24, 2021 8:52 AM
> 
> Thanks. The patch for HEAD looks good to me. Regarding the patch for PG14, I
> think we need to update the comment as well:
> 
> @@ -987,7 +986,7 @@ AlterSubscription(AlterSubscriptionStmt *stmt, bool
> isTopLevel)
>       PreventInTransactionBlock(isTopLevel, "ALTER SUBSCRIPTION with
> refresh");
> 
>       /* Only refresh the added/dropped list of publications. */
> -     sub->publications = stmt->publication;
> +     sub->publications = publist;
> 

Thanks for the comment, attach new version patch which fixed it.

Best regards,
Hou zj

Commits

  1. Fix Alter Subscription's Add/Drop Publication behavior.

  2. ALTER SUBSCRIPTION ... ADD/DROP PUBLICATION