RE: Fix premature xmin advancement during fast forward decoding
Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com>
From: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, shveta malik <shveta.malik@gmail.com>
Date: 2025-04-27T07:03:08Z
Lists: pgsql-hackers
Attachments
- v2-0001-HEAD-PG17-Fix-premature-xmin-advancement-during-fast-forwar.patch (application/octet-stream) patch v2-0001
- v2-0001-PG13-16-Fix-premature-xmin-advancement-during-fast-forwar.patch.txt (text/plain)
On Sun, Apr 27, 2025 at 2:07 PM Masahiko Sawada wrote: > > On Sat, Apr 26, 2025 at 5:01 AM Amit Kapila <amit.kapila16@gmail.com> > wrote: > > > > On Sat, Apr 26, 2025 at 12:01 AM Masahiko Sawada > <sawada.mshk@gmail.com> wrote: > > > > > > On Fri, Apr 25, 2025 at 4:42 AM Amit Kapila <amit.kapila16@gmail.com> > wrote: > > > > > > > > Can you think of any better ideas? > > > > > > No idea. Hmm, there seems no reasonable way to fix this issue for > > > back branches. I consented to the view that these costs were > > > something that we should have paid from the beginning. > > > > > > > Right, I feel we should go with the simple change proposed by Hou-San > > for now to fix the bug. If, in the future, we encounter any cases > > where such optimizations can help for fast-forward mode, then we can > > consider it. Does that sound reasonable to you? > > Yes, agreed with this approach. +1. Thanks for the discussion! Here is the V2 patch (including both HEAD and back-branch versions) which merged Amit's suggestions for the comments. It can pass regression and pgindent check. I also adjusted the commit message to mention the commit f49a80c4 as suggested by Amit. Best Regards, Hou zj
Commits
-
Fix xmin advancement during fast_forward decoding.
- d65485b02b1f 13.21 landed
- aaf9e95e8764 18.0 landed
- 36148b22ee09 17.5 landed
- 21a7caeeb948 16.9 landed
- f6429bd7db5e 15.13 landed
- 1f63b3626a52 14.18 landed
-
Fix "base" snapshot handling in logical decoding
- f49a80c481f7 11.0 cited