RE: row filtering for logical replication
Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com>
Commits
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Release cache tuple when no longer needed
- ed0fbc8e5ac9 15.0 landed
-
Add some additional tests for row filters in logical replication.
- ceb57afd3ce1 15.0 landed
-
Fix one of the tests introduced in commit 52e4f0cd47.
- cfb4e209ec15 15.0 landed
-
Allow specifying row filters for logical replication of tables.
- 52e4f0cd472d 15.0 landed
-
Move scanint8() to numutils.c
- cfc7191dfea3 15.0 cited
-
Replace Test::More plans with done_testing
- 549ec201d613 15.0 cited
-
Reduce relcache access in WAL sender streaming logical changes
- 6ce16088bfed 15.0 cited
-
Small cleanups related to PUBLICATION framework code
- c9105dd3660f 15.0 cited
-
Add a view to show the stats of subscription workers.
- 8d74fc96db5f 15.0 cited
-
Allow publishing the tables of schema.
- 5a2832465fd8 15.0 cited
-
Doc: improve documentation of CREATE/ALTER SUBSCRIPTION.
- 1882d6cca161 15.0 cited
-
Add PublicationTable and PublicationRelInfo structs
- 0c6828fa987b 15.0 cited
-
Remove unused argument "txn" in maybe_send_schema().
- 93d573d86571 15.0 cited
-
Add prepare API support for streaming transactions in logical replication.
- 63cf61cdeb7b 15.0 cited
-
Unify PostgresNode's new() and get_new_node() methods
- 201a76183e20 15.0 cited
-
Use l*_node() family of functions where appropriate
- 2b00db4fb0c7 15.0 cited
-
Add support for prepared transactions to built-in logical replication.
- a8fd13cab0ba 15.0 cited
-
Restore the portal-level snapshot after procedure COMMIT/ROLLBACK.
- ef9480509622 11.13 cited
-
Rename a parse node to be more general
- 91d1f2d30210 14.0 landed
-
Remove unused column atttypmod from initial tablesync query
- 4ad31bb2ef25 14.0 landed
-
SEARCH and CYCLE clauses
- 3696a600e229 14.0 cited
On Wednesday, January 5, 2022 2:45 PM Amit Kapila <amit.kapila16@gmail.com> wrote: > > On Wed, Jan 5, 2022 at 11:04 AM Peter Smith <smithpb2250@gmail.com> > wrote: > > > > > > 11. src/backend/utils/cache/relcache.c - GetRelationPublicationActions > > > > Something seemed slightly fishy with the code doing the memcpy, > > because IIUC is possible for the GetRelationPublicationInfo function > > to return without setting the relation->rd_pubactions. Is it just > > missing an Assert or maybe a comment to say such a scenario is not > > possible in this case because the is_publishable_relation was already > > tested? > > > > I think it would be good to have an Assert for a valid value of > relation->rd_pubactions before doing memcpy. Alternatively, in > function, GetRelationPublicationInfo(), we can have an Assert when > rd_rfcol_valid is true. I think we can add comments atop > GetRelationPublicationInfo about pubactions. > > > > > 13. src/include/utils/rel.h - comment typos > > > > @@ -164,6 +164,13 @@ typedef struct RelationData > > PublicationActions *rd_pubactions; /* publication actions */ > > > > /* > > + * true if the columns referenced in row filters from all the > > + publications > > + * the relation is in are part of replica identity, or the > > + publication > > + * actions do not include UPDATE and DELETE. > > + */ > > > > Some minor rewording of the comment: > > > ... > > "UPDATE and DELETE" --> "UPDATE or DELETE" > > > > The existing comment seems correct to me. Hou-San can confirm it once as I > think this is written by him. I think the code comment is trying to say "the publication does not include UPDATE and also does not include DELETE" I am not too sure about the grammar, I noticed there is some other places in the code use " no updates or deletes ", so maybe it's fine to change it to "UPDATE or DELETE" Best regards, Hou zj