Horton

RE: row filtering for logical replication

Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com>

View thread
From: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Euler Taveira <euler@eulerto.com>, Greg Nancarrow <gregn4422@gmail.com>, vignesh C <vignesh21@gmail.com>, Ajin Cherian <itsajin@gmail.com>, "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>, Dilip Kumar <dilipbalaut@gmail.com>, Rahila Syed <rahilasyed90@gmail.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Önder Kalacı <onderkalaci@gmail.com>, japin <japinli@hotmail.com>, Michael Paquier <michael@paquier.xyz>, David Steele <david@pgmasters.net>, Craig Ringer <craig@2ndquadrant.com>, Amit Langote <amitlangote09@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-02-03T15:10:48Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Release cache tuple when no longer needed

  2. Add some additional tests for row filters in logical replication.

  3. Fix one of the tests introduced in commit 52e4f0cd47.

  4. Allow specifying row filters for logical replication of tables.

  5. Move scanint8() to numutils.c

  6. Replace Test::More plans with done_testing

  7. Reduce relcache access in WAL sender streaming logical changes

  8. Small cleanups related to PUBLICATION framework code

  9. Add a view to show the stats of subscription workers.

  10. Allow publishing the tables of schema.

  11. Doc: improve documentation of CREATE/ALTER SUBSCRIPTION.

  12. Add PublicationTable and PublicationRelInfo structs

  13. Remove unused argument "txn" in maybe_send_schema().

  14. Add prepare API support for streaming transactions in logical replication.

  15. Unify PostgresNode's new() and get_new_node() methods

  16. Use l*_node() family of functions where appropriate

  17. Add support for prepared transactions to built-in logical replication.

  18. Restore the portal-level snapshot after procedure COMMIT/ROLLBACK.

  19. Rename a parse node to be more general

  20. Remove unused column atttypmod from initial tablesync query

  21. SEARCH and CYCLE clauses

Attachments

On Tuesday, February 1, 2022 7:22 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> 
> On Tue, Feb 1, 2022 at 9:15 AM houzj.fnst@fujitsu.com <houzj.fnst@fujitsu.com>
> wrote:
> >
> > On Monday, January 31, 2022 9:02 PM Amit Kapila
> > <amit.kapila16@gmail.com>
> > >
> 
> Review Comments:
> ===============
> 1.
> + else if (IsA(node, OpExpr))
> + {
> + /* OK, except user-defined operators are not allowed. */ if (((OpExpr
> + *) node)->opno >= FirstNormalObjectId) errdetail_msg = _("User-defined
> + operators are not allowed."); }
> 
> Is it sufficient to check only the allowed operators for OpExpr? Don't we need to
> check opfuncid to ensure that the corresponding function is immutable? Also,
> what about opresulttype, opcollid, and inputcollid? I think we don't want to allow
> user-defined types or collations but as we are restricting the opexp to use a
> built-in operator, those should not be present in such an expression. If that is the
> case, then I think we can add a comment for the same.
> 
> 2. Can we handle RelabelType node in
> check_simple_rowfilter_expr_walker()? I think you need to check resulttype and
> collation id to ensure that they are not user-defined.
> There doesn't seem to be a need to check resulttypmod as that refers to
> pg_attribute.atttypmod and that can't have anything unsafe. This helps us to
> handle cases like the following which currently gives an
> error:
> create table t1(c1 int, c2 varchar(100)); create publication pub1 for table t1 where
> (c2 < 'john');
> 
> 3. Similar to above, don't we need to consider disallowing non-built-in collation
> of Var type nodes? Now, as we are only supporting built-in types this might not
> be required. So, probably a comment would suffice.

I adjusted the code in check_simple_rowfilter_expr_walker to
handle the collation/type/function.

> 4.
> A minor nitpick in tab-complete:
> postgres=# Alter PUBLICATION pub1 ADD TABLE t2 WHERE ( c2 > 10)
> ,        WHERE (
> 
> After the Where clause, it should not allow adding WHERE. This doesn't happen
> for CREATE PUBLICATION case.

I will look into this and change it soon.

Attach the V76 patch set which addressed above comments and comments from[1][2].

[1] https://www.postgresql.org/message-id/CAA4eK1L6hLRxFVphDO8mwuguc9kVdMu-DT2Dw2GXHwvprLoxrw%40mail.gmail.com
[2] https://www.postgresql.org/message-id/CAA4eK1L6hLRxFVphDO8mwuguc9kVdMu-DT2Dw2GXHwvprLoxrw%40mail.gmail.com

Best regards,
Hou zj