RE: Support logical replication of DDLs

Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com>

From: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>

To: shveta malik <shveta.malik@gmail.com>

Cc: vignesh C <vignesh21@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, Ajin Cherian <itsajin@gmail.com>, "wangw.fnst@fujitsu.com" <wangw.fnst@fujitsu.com>, Runqi Tian <runqidev@gmail.com>, Peter Smith <smithpb2250@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, li jie <ggysxcq@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Masahiko Sawada <sawada.mshk@gmail.com>, Japin Li <japinli@hotmail.com>, rajesh singarapu <rajesh.rs0541@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Zheng Li <zhengli10@gmail.com>

Date: 2023-04-07T03:22:36Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add a run_as_owner option to subscriptions.
- 482675987bcd 16.0 cited
Refactor pgoutput_change().
- da324d6cd45b 16.0 cited
Print the correct aliases for DML target tables in ruleutils.
- df931e9ab35b 11.20 landed
- c8a5f1685fb7 15.3 landed
- 4efb4f0d4878 13.11 landed
- 3dd287c14fac 12.15 landed
- 393430f57544 16.0 landed
- 14345f3c6a7b 14.8 landed
Fix object identity string for transforms
- 9a312562314a 16.0 landed
Add grantable MAINTAIN privilege and pg_maintain role.
- 60684dd834a2 16.0 cited
Get rid of recursion-marker values in enum AlterTableType
- 840ff5f451cd 16.0 cited
Release cache tuple when no longer needed
- ed0fbc8e5ac9 15.0 cited
Empty search_path in logical replication apply worker and walsender.
- 11da97024abb 14.0 cited
Refactor format_type APIs to be more modular
- a26116c6cbf4 11.0 cited
Use wrappers of PG_DETOAST_DATUM_PACKED() more.
- 3a0d473192b2 10.0 cited

Attachments

0001-Deparser-for-Table-DDL-commands-and-exten-2023_04_07-2.patch (application/octet-stream) patch 0001
0005-Apply-the-DDL-change-as-that-same-user-th-2023_04_07-2.patch (application/octet-stream) patch 0005
0002-DDL-replication-for-Table-DDL-commands-2023_04_07-2.patch (application/octet-stream) patch 0002
0003-Deparser-for-INDEX-DDL-commands-2023_04_07-2.patch (application/octet-stream) patch 0003
0004-DDL-replication-for-index-DDL-commands-2023_04_07-2.patch (application/octet-stream) patch 0004
0006-Deparser-and-DDL-replication-for-the-rest-2023_04_07-2.patch (application/octet-stream) patch 0006

On Friday, April 7, 2023 11:13 AM houzj.fnst@fujitsu.com <houzj.fnst@fujitsu.com>
> 
> On Tuesday, April 4, 2023 7:35 PM shveta malik <shveta.malik@gmail.com>
> wrote:
> >
> > On Tue, Apr 4, 2023 at 8:43 AM houzj.fnst@fujitsu.com
> > <houzj.fnst@fujitsu.com> wrote:
> >
> > > Attach the new version patch set which did the following changes:
> > >
> >
> > Hello,
> >
> > I tried below:
> > pubnew=# ALTER PUBLICATION mypub2 SET (ddl = 'table'); ALTER
> > PUBLICATION
> >
> > pubnew=# \dRp+
> >                                         Publication mypub2 Owner  |
> > All tables
> > | All DDLs | Table DDLs |
> > --------+------------+----------+------------+---------
> > shveta |         t          | f               | f
> > (1 row)
> >
> > I still see 'Table DDLs' as false and ddl replication did not work for this case.
> 
> Thanks for reporting.
> 
> Attach the new version patch which include the following changes:
> * Fix the above bug for ALTER PUBLICATION SET.
> * Modify the corresponding event trigger when user execute ALTER
> PUBLICATION SET to change the ddl option.
> * Fix a miss in pg_dump's code which causes CFbot failure.
> * Rebase the patch due to recent commit 4826759.

Sorry, there was a miss when rebasing the patch which could cause the
CFbot to fail and here is the correct patch set.

Best Regards,
Hou zj