Horton

Thread

Commits

  1. Fix some comments in fmgr.c

  1. Fix redundant comments in fmgr.c

    Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com> — 2021-04-22T11:44:10Z

    Hi,

I found some possible redundant comments in fmgr.c

1.
fmgr_symbol(Oid functionId, char **mod, char **fn)
{
              HeapTuple          procedureTuple;
              Form_pg_proc procedureStruct;
              bool                     isnull;
              Datum                 prosrcattr;
            Datum                 probinattr;
-             /* Otherwise we need the pg_proc entry */
              procedureTuple = SearchSysCache1(PROCOID, ObjectIdGetDatum(functionId));

I guess the comment here was miscopied from fmgr_info_cxt_security:



2.
              if (!HeapTupleIsValid(procedureTuple))
                          elog(ERROR, "cache lookup failed for function %u", functionId);
            procedureStruct = (Form_pg_proc) GETSTRUCT(procedureTuple);
-             /*
-             */

Best regards,
houzj

  2. Re: Fix redundant comments in fmgr.c

    Michael Paquier <michael@paquier.xyz> — 2021-04-23T04:36:56Z

    On Thu, Apr 22, 2021 at 11:44:10AM +0000, houzj.fnst@fujitsu.com wrote:
> I found some possible redundant comments in fmgr.c

Thanks, fixed.  I have noticed one extra inconsistency at the top of
fmgr_symbol().

> I guess the comment here was miscopied from fmgr_info_cxt_security:

Right, coming right from the fast path in the other function.
--
Michael