RE: Conflict detection for update_deleted in logical replication

Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com>

From: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>

To: vignesh C <vignesh21@gmail.com>

Cc: Amit Kapila <amit.kapila16@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, Nisha Moond <nisha.moond412@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, shveta malik <shveta.malik@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2025-01-09T09:14:04Z

Lists: pgsql-hackers

Attachments

v20-0002-Maintain-the-replication-slot-in-logical-launche.patch (application/octet-stream) patch v20-0002
v20-0003-Add-a-retain_conflict_info-option-to-subscriptio.patch (application/octet-stream) patch v20-0003
v20-0001-Maintain-the-oldest-non-removeable-tranasction-I.patch (application/octet-stream) patch v20-0001
v20-0004-Add-a-tap-test-to-verify-the-management-of-the-n.patch (application/octet-stream) patch v20-0004
v20-0005-Support-the-conflict-detection-for-update_delete.patch (application/octet-stream) patch v20-0005

On Wednesday, January 8, 2025 3:00 PM vignesh C <vignesh21@gmail.com> wrote:
> 
> On Tue, 7 Jan 2025 at 18:04, Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com>
> wrote:
> >
> > Attached the V19 patch which addressed comments in [1][2][3][4][5][6][7].
> 
> Few comments:

Thanks for the comments. Here is the V20 patch which addressed them and
comments in [1][2].

I also modified some comments in 0003 to be consistent with the new
option name.

[1] https://www.postgresql.org/message-id/CABdArM70XAQOK1GiXJC4gpXewGGYxixxVyhxCYXhVFDqnjLL4A%40mail.gmail.com
[2] https://www.postgresql.org/message-id/CALDaNm3%2Bx%2BZRE9wynMofvc_ZxsLXKHpyS7LYxnP-a2%3DRQE-4uA%40mail.gmail.com

Best Regards,
Hou zj

Commits

Fix intermittent BF failures in 035_conflicts.
- 0f42206531b3 19 (unreleased) landed
Resume conflict-relevant data retention automatically.
- 0d48d393d465 19 (unreleased) landed
Fix intermittent test failure introduced in 6456c6e2c4.
- 01d793698f59 19 (unreleased) landed
Fix Coverity issue reported in commit a850be2fe.
- 5ac3c1ac22cb 19 (unreleased) landed
Add test to prevent premature removal of conflict-relevant data.
- 6456c6e2c4ad 19 (unreleased) landed
Post-commit review fixes for 228c370868.
- 1f7e9ba3ac4e 19 (unreleased) landed
Add max_retention_duration option to subscriptions.
- a850be2fe653 19 (unreleased) landed
Detect and report update_deleted conflicts.
- fd5a1a0c3e56 19 (unreleased) landed
Preserve conflict-relevant data during logical replication.
- 228c37086855 19 (unreleased) landed
Integrate FullTransactionIds deeper into two-phase code
- 62a17a92833d 19 (unreleased) cited
Improve checks for GUC recovery_target_timeline
- fd7d7b719137 19 (unreleased) cited
Prevent excessive delays before launching new logrep workers.
- fd519419c948 18.0 cited
Keep WAL segments by slot's last saved restart LSN
- ca307d5cec90 18.0 cited
Rework some code handling pg_subscription data in psql and pg_dump
- 08691ea958c2 18.0 cited
Use generateClonedIndexStmt to propagate CREATE INDEX to partitions.
- 68dfecbef210 18.0 cited