RE: Perform streaming logical transactions by background workers and parallel apply
Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com>
Attachments
- v63-0001-Perform-streaming-logical-transactions-by-parall.patch (application/octet-stream) patch v63-0001
- v63-0002-Test-streaming-parallel-option-in-tap-test.patch (application/octet-stream) patch v63-0002
- v63-0003-Allow-streaming-every-change-without-waiting-til.patch (application/octet-stream) patch v63-0003
- v63-0004-Add-GUC-stream_serialize_threshold-and-test-seri.patch (application/octet-stream) patch v63-0004
- v63-0005-Stop-extra-worker-if-GUC-was-changed.patch (application/octet-stream) patch v63-0005
- v63-0006-Retry-to-apply-streaming-xact-only-in-apply-work.patch (application/octet-stream) patch v63-0006
- v63-0007-Add-a-main_worker_pid-to-pg_stat_subscription.patch (application/octet-stream) patch v63-0007
On Tuesday, December 20, 2022 5:12 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Mon, Dec 19, 2022 at 6:17 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > On Sat, Dec 17, 2022 at 7:34 PM houzj.fnst@fujitsu.com
> > <houzj.fnst@fujitsu.com> wrote:
> > >
> > > Agreed. I have addressed all the comments and did some cosmetic changes.
> > > Attach the new version patch set.
> > >
> >
> > Few comments:
> > ============
> >
>
> Few more minor points:
> 1.
> -static inline void
> +void
> changes_filename(char *path, Oid subid, TransactionId xid) {
>
> This function seems to be used only in worker.c. So, what is the need to make it
> extern?
Oh, I forgot to revert this change after removing the one caller outside of worker.c.
Changed.
>
> 2. I have made a few changes in the comments. See attached. This is atop my
> yesterday's top-up patch.
Thanks, I have checked and merged this.
> I think we should merge the 0001 and 0002 patches as they need to be
> committed together.
Merged and ran the pgident for the patch set.
Attach the new version patch set which addressed all comments so far.
Best regards,
Hou zj
Commits
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Fix invalid memory access during the shutdown of the parallel apply worker.
- 3d144c6c8602 16.0 landed
-
Fix assertion failure in apply worker.
- de63f8dadee4 16.0 landed
-
Use elog to report unexpected action in handle_streamed_transaction().
- 781ac42d43ab 16.0 landed
-
Use appropriate wait event when sending data in the apply worker.
- d9d7fe68d35e 16.0 landed
-
Allow the logical_replication_mode to be used on the subscriber.
- 9f2213a7c575 16.0 landed
-
Rename GUC logical_decoding_mode to logical_replication_mode.
- 1e8b61735cfb 16.0 landed
-
Display the leader apply worker's PID for parallel apply workers.
- d540a02a724b 16.0 landed
-
Improve the code to decide and process the apply action.
- c981d9145dea 16.0 landed
-
Document the newly added wait events added by commit 216a784829.
- cd06ccd78fcf 16.0 landed
-
Perform apply of large transactions by parallel workers.
- 216a784829c2 16.0 landed
-
Wake up a subscription's replication worker processes after DDL.
- c6e1f62e2cee 16.0 cited
-
Add copyright notices to meson files
- 8284cf5f746f 16.0 cited
-
Better document logical replication parameters
- a8500750ca0a 16.0 cited
-
Add a common function to generate the origin name.
- 776e1c8a5d14 16.0 cited
-
Harmonize parameter names in storage and AM code.
- bfcf1b34805f 16.0 cited
-
Avoid using list_length() to test for empty list.
- efd0c16becbf 16.0 cited
-
Improve two comments related to a boolean DefElem's value
- 8445f5a21d40 16.0 cited
-
Fix partition table's REPLICA IDENTITY checking on the subscriber.
- 26b3455afaa9 15.0 cited
-
Fix data inconsistency between publisher and subscriber.
- b7658c24c7c1 15.0 cited
-
Fix cache look-up failures while applying changes in logical replication.
- 5a97b1325453 15.0 cited