Horton

RE: row filtering for logical replication

Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com>

View thread
From: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Euler Taveira <euler@eulerto.com>, Greg Nancarrow <gregn4422@gmail.com>, vignesh C <vignesh21@gmail.com>, Ajin Cherian <itsajin@gmail.com>, "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>, Dilip Kumar <dilipbalaut@gmail.com>, Rahila Syed <rahilasyed90@gmail.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Önder Kalacı <onderkalaci@gmail.com>, japin <japinli@hotmail.com>, Michael Paquier <michael@paquier.xyz>, David Steele <david@pgmasters.net>, Craig Ringer <craig@2ndquadrant.com>, Amit Langote <amitlangote09@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-02-01T03:45:21Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Release cache tuple when no longer needed

  2. Add some additional tests for row filters in logical replication.

  3. Fix one of the tests introduced in commit 52e4f0cd47.

  4. Allow specifying row filters for logical replication of tables.

  5. Move scanint8() to numutils.c

  6. Replace Test::More plans with done_testing

  7. Reduce relcache access in WAL sender streaming logical changes

  8. Small cleanups related to PUBLICATION framework code

  9. Add a view to show the stats of subscription workers.

  10. Allow publishing the tables of schema.

  11. Doc: improve documentation of CREATE/ALTER SUBSCRIPTION.

  12. Add PublicationTable and PublicationRelInfo structs

  13. Remove unused argument "txn" in maybe_send_schema().

  14. Add prepare API support for streaming transactions in logical replication.

  15. Unify PostgresNode's new() and get_new_node() methods

  16. Use l*_node() family of functions where appropriate

  17. Add support for prepared transactions to built-in logical replication.

  18. Restore the portal-level snapshot after procedure COMMIT/ROLLBACK.

  19. Rename a parse node to be more general

  20. Remove unused column atttypmod from initial tablesync query

  21. SEARCH and CYCLE clauses

Attachments

On Monday, January 31, 2022 9:02 PM Amit Kapila <amit.kapila16@gmail.com>
> 
> On Mon, Jan 31, 2022 at 1:08 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > On Mon, Jan 31, 2022 at 7:27 AM houzj.fnst@fujitsu.com
> > <houzj.fnst@fujitsu.com> wrote:
> > >
> > > On Monday, January 31, 2022 8:53 AM Peter Smith
> <smithpb2250@gmail.com> wrote:
> > > >
> > > > PSA v73*.
> > > >
> > > > (A rebase was needed due to recent changes in tab-complete.c.
> > > > Otherwise, v73* is the same as v72*).
> > >
> > > Thanks for the rebase.
> > > Attach the V74 patch set which did the following changes:
> > >
> >
> > Few comments:
> > =============
> >
> 
> Few more minor comments:
> 1.
> + if (relentry->attrmap)
> + {
> + TupleDesc tupdesc  = RelationGetDescr(relation); TupleTableSlot
> + *tmp_slot = MakeTupleTableSlot(tupdesc,
> +   &TTSOpsVirtual);
> +
> + new_slot = execute_attr_map_slot(relentry->attrmap,
> + new_slot,
> + tmp_slot);
> 
> I think we don't need these additional variables tupdesc and tmp_slot.
> You can directly use MakeTupleTableSlot instead of tmp_slot, which will make
> this and nearby code look better.

Changed.

> 2.
> + if (pubrinfo->pubrelqual)
> + appendPQExpBuffer(query, " WHERE (%s)", pubrinfo->pubrelqual);
> + appendPQExpBufferStr(query, ";\n");
> 
> Do we really need additional '()' for rwo filter expression here? See the below
> output from pg_dump:
> 
> ALTER PUBLICATION pub1 ADD TABLE ONLY public.t1 WHERE ((c1 < 100));

I will investigate this and change this later if needed.

> 3.
> + /* row filter (if any) */
> + if (pset.sversion >= 150000)
> + {
> + if (!PQgetisnull(result, i, 1))
> + appendPQExpBuffer(&buf, " WHERE %s", PQgetvalue(result, i, 1)); }
> 
> I don't think we need this version check if while forming query we use NULL as
> the second column in the corresponding query for v < 150000.

Changed.

Attach the V75 patch set which address the above, Amit's[1] and Greg's[2][3] comments.

The new version patch also includes the following changes:

- run pgindent
- adjust some comments
- remove some unnecessary ExecClearTuple
- slightly improve the row filter of toast case by removing some unnecessary
  memory allocation and directly return the modified new slot instead of
  copying it again.

[1] https://www.postgresql.org/message-id/CAA4eK1LjyiPkwOki3n%2BQfORmBQLUvsvBfifhZMh%2BquAJTuRU_w%40mail.gmail.com
[2] https://www.postgresql.org/message-id/CAJcOf-fR_BKHNuz7AXCWuk40ESVOr%3DDkXf3evbNNi4M4V_5agQ%40mail.gmail.com
[3] https://www.postgresql.org/message-id/CAJcOf-fR_BKHNuz7AXCWuk40ESVOr%3DDkXf3evbNNi4M4V_5agQ%40mail.gmail.com

Best regards,
Hou zj