RE: Fix slot synchronization with two_phase decoding enabled

Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com>

From: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>

To: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, Amit Kapila <amit.kapila16@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>

Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Nisha Moond <nisha.moond412@gmail.com>

Date: 2025-04-17T12:46:05Z

Lists: pgsql-hackers

On Thu, Apr 17, 2025 at 8:44 PM Zhijie Hou (Fujitsu) wrote:

> 
> Hi,
> 
> The recently added tests for slotsync on two-phase enabled slots 
> failed[1] due to a broken assertion triggered while decoding the 
> COMMIT PREPARED record on the promoted standby.

Here is the missing link:

[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=sidewinder&dt=2025-04-09%2010%3A36%3A46

Best Regards,
Hou zj

Commits

Don't retreat slot's confirmed_flush LSN.
- ad5eaf390c58 18.0 landed
- 7318f241d29c 17.6 landed
- c0f51fde534d 16.10 landed
- 9d1a62359606 15.14 landed
- e68459489c20 14.19 landed
- e323d9df002d 13.22 landed
Fix assertion failure during decoding from synced slots.
- 3ff2a1f0c9e8 18.0 landed
Fix xmin advancement during fast_forward decoding.
- d65485b02b1f 13.21 landed
- aaf9e95e8764 18.0 landed
- 36148b22ee09 17.5 landed
- 21a7caeeb948 16.9 landed
- f6429bd7db5e 15.13 landed
- 1f63b3626a52 14.18 landed
Fix slot synchronization for two_phase enabled slots.
- 4868c96bc8c6 18.0 landed
Again match pg_user_mappings to information_schema.user_mapping_options.
- b6e39ca92eee 9.4.13 cited