RE: [BUG] wrong refresh when ALTER SUBSCRIPTION ADD/DROP PUBLICATION
Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com>
From: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Japin Li <japinli@hotmail.com>
Date: 2021-08-23T09:15:13Z
Lists: pgsql-hackers
Attachments
- v5-0001-Fix-Alter-Subscription-Add-Drop-Publication-refresh-.patch (application/octet-stream) patch v5-0001
On Mon, Aug 23, 2021 12:59 PM Amit Kapila <amit.kapila16@gmail.com> wrote: > > On Sat, Aug 7, 2021 at 6:53 PM houzj.fnst@fujitsu.com <houzj.fnst@fujitsu.com> wrote: > > > > Personally, I also think it will be better to make the behavior consistent. > > Attach the new version patch make both ADD and DROP behave the same as > > SET PUBLICATION which refresh all the publications. > > > > I think we can have tests in the separate test file (alter_sub_pub.pl) like you > earlier had in one of the versions. Use some meaningful names for tables > instead of temp1, temp2 as you had in the previous version. > Otherwise, the code changes look good to me. Thanks for the comment. Attach new version patch which did the following changes. * move the tests to a separate test file (024_alter_sub_pub.pl) * adjust the document of copy_data option * add tab-complete for copy_data option when ALTER DROP publication. Best regards, Hou zj
Commits
-
Fix Alter Subscription's Add/Drop Publication behavior.
- 5cfcd46e9d29 14.0 landed
- 1046a69b3087 15.0 landed
-
ALTER SUBSCRIPTION ... ADD/DROP PUBLICATION
- 82ed7748b710 14.0 cited