RE: Conflict detection for update_deleted in logical replication

Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com>

From: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>

To: Amit Kapila <amit.kapila16@gmail.com>

Cc: shveta malik <shveta.malik@gmail.com>, vignesh C <vignesh21@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Nisha Moond <nisha.moond412@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2025-05-26T07:16:29Z

Lists: pgsql-hackers

Attachments

v32-0006-Add-a-tap-test-to-verify-the-management-of-the-n.patch (application/octet-stream) patch v32-0006
v32-0002-Maintain-the-replication-slot-in-logical-launche.patch (application/octet-stream) patch v32-0002
v32-0003-Add-a-retain_conflict_info-option-to-subscriptio.patch (application/octet-stream) patch v32-0003
v32-0004-Introduce-a-new-GUC-max_conflict_retention_durat.patch (application/octet-stream) patch v32-0004
v32-0005-Re-create-the-replication-slot-if-the-conflict-r.patch (application/octet-stream) patch v32-0005
v32-0007-Support-the-conflict-detection-for-update_delete.patch (application/octet-stream) patch v32-0007
v32-0001-Maintain-the-oldest-non-removable-transaction-ID.patch (application/octet-stream) patch v32-0001

On Fri, May 23, 2025 at 7:08 PM Amit Kapila wrote:

> 
> On Thu, May 22, 2025 at 8:28 AM Zhijie Hou (Fujitsu) 
> <houzj.fnst@fujitsu.com> wrote:
> >
> > Attaching the V31 patch set which addressed comments in [1]~[8].
> >
> 
> Few comments:
> 
> Apart from the above comments, I made a few other cosmetic changes in 
> the attached.

Thanks for the comments and diff, I have merged them into the latest patch set.

Attaching the V32 patch set which addressed comments in [1]~[5].

[1] https://www.postgresql.org/message-id/CAFiTN-vd%3DrF0CK1sw-vdOAYSRaV_GMrO3VR0yTv%3Df2GKyOw%3Dbg%40mail.gmail.com
[2] https://www.postgresql.org/message-id/CAA4eK1Kd05tu9n%2Ba4LAmK-UWxTfcaanuLYD2e1Lt-2kiKzvwTw%40mail.gmail.com
[3] https://www.postgresql.org/message-id/CABPTF7U8SKpw%2BHepd4MJ%2BoPBAWdFmYukyk92TKLkZGHhQD4KaQ%40mail.gmail.com
[4] https://www.postgresql.org/message-id/CAA4eK1J%2BdmsB%3Dod4pkGBjZkeurpWGuRXOeXBbNRbh3hVUr7DxQ%40mail.gmail.com
[5] https://www.postgresql.org/message-id/CAJpy0uDEKO%2BqX1Y7WQar_o6nCPBQtenjG%3D8fE2NvKcwtFRs6hw%40mail.gmail.com

Best Regards,
Hou zj

Commits

Fix intermittent BF failures in 035_conflicts.
- 0f42206531b3 19 (unreleased) landed
Resume conflict-relevant data retention automatically.
- 0d48d393d465 19 (unreleased) landed
Fix intermittent test failure introduced in 6456c6e2c4.
- 01d793698f59 19 (unreleased) landed
Fix Coverity issue reported in commit a850be2fe.
- 5ac3c1ac22cb 19 (unreleased) landed
Add test to prevent premature removal of conflict-relevant data.
- 6456c6e2c4ad 19 (unreleased) landed
Post-commit review fixes for 228c370868.
- 1f7e9ba3ac4e 19 (unreleased) landed
Add max_retention_duration option to subscriptions.
- a850be2fe653 19 (unreleased) landed
Detect and report update_deleted conflicts.
- fd5a1a0c3e56 19 (unreleased) landed
Preserve conflict-relevant data during logical replication.
- 228c37086855 19 (unreleased) landed
Integrate FullTransactionIds deeper into two-phase code
- 62a17a92833d 19 (unreleased) cited
Improve checks for GUC recovery_target_timeline
- fd7d7b719137 19 (unreleased) cited
Prevent excessive delays before launching new logrep workers.
- fd519419c948 18.0 cited
Keep WAL segments by slot's last saved restart LSN
- ca307d5cec90 18.0 cited
Rework some code handling pg_subscription data in psql and pg_dump
- 08691ea958c2 18.0 cited
Use generateClonedIndexStmt to propagate CREATE INDEX to partitions.
- 68dfecbef210 18.0 cited