Horton

Thread

Commits

  1. Remove unused argument "txn" in maybe_send_schema().

  2. Add support for streaming to built-in logical replication.

  1. param 'txn' not used in function maybe_send_schema()

    Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com> — 2021-07-30T13:27:23Z

    Hi,

When reviewing logicalreplication related patches, I noticed the function
param ReorderBufferTXN *txn not used in the function maybe_send_schema(). Since
this is not an external function, I think it might be better to remove the unused paramater.

Best regards,
Houzj

  2. Re: param 'txn' not used in function maybe_send_schema()

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2021-07-31T01:08:03Z

    
On 2021/07/30 22:27, houzj.fnst@fujitsu.com wrote:
> Hi,
> 
> When reviewing logicalreplication related patches, I noticed the function
> param ReorderBufferTXN *txn not used in the function maybe_send_schema(). Since
> this is not an external function, I think it might be better to remove the unused paramater.

+1

Seems commit 464824323e accidentally added the argument though
it's not used in maybe_send_schema(). I *guess* that it was used
in the patches in dev early stage, but it's changed so that no longer used
while it's being reviewed. But maybe we forgot to remove it.

Barring any objection, I will commit the patch.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

  3. Re: param 'txn' not used in function maybe_send_schema()

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2021-08-05T08:51:25Z

    
On 2021/07/31 10:08, Fujii Masao wrote:
> Barring any objection, I will commit the patch.

Pushed. Thanks!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION