Horton

RE: [BUG]Invalidate relcache when setting REPLICA IDENTITY

Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com>

View thread View on postgr.es
From: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Euler Taveira <euler@eulerto.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>
Date: 2021-11-12T06:10:07Z
Lists: pgsql-hackers

Attachments

On Fri, Nov 12, 2021 1:33 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> On Fri, Nov 12, 2021 at 10:50 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > But won't that generate invalidation for the rel twice in the case
> > (change Replica Identity from Nothing to some index) you mentioned in
> > the previous email?
> >
> 
> Oh, I see the point. I think this is okay because
> AddRelcacheInvalidationMessage doesn't allow to add duplicate rel
> invalidation. If that is the case I wonder why not simply register
> invalidation without any check in the for loop as was the case with
> Tang's original patch?

OK, I also think the code in Tang's original patch is fine.
Attach the patch which register invalidation without any check in the for loop.

Best regards,
Hou zj

Commits

  1. Invalidate relcache when changing REPLICA IDENTITY index.