RE: Conflict detection for update_deleted in logical replication

Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com>

From: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>

To: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, shveta malik <shveta.malik@gmail.com>

Cc: Amit Kapila <amit.kapila16@gmail.com>, Nisha Moond <nisha.moond412@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, vignesh C <vignesh21@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>

Date: 2025-08-28T02:32:06Z

Lists: pgsql-hackers

Attachments

v67-0003-Add-a-dead_tuple_retention_active-column-in-pg_s.patch (application/octet-stream) patch v67-0003
v67-0001-Introduce-a-max_retention_duration-option-to-sub.patch (application/octet-stream) patch v67-0001
v67-0002-Resume-retaining-the-information-for-conflict-de.patch (application/octet-stream) patch v67-0002

On Wednesday, August 27, 2025 11:30 AM Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com> wrote:
> 
> Here is V66 patch set which includes the following changes:
> 
> [0001]
> * Enhanced documentation according to Dilip's comments [1].
> * Simplified logic by directly using the leader's oldest_nonremovable_xid to
>   locate deleted tuples, according to Amit's comments [2].
> * Merged Amit's diff [2].
> * Integrated the new NOTICE into the existing CheckSubDeadTupleRetention
>   function according to Amit's feedback [3].
> * Some other adjustments according to feedback from [2] [3].
> 
> [0002]
> * Refactored code according to Shveta's comments [4].
> * Removed an unnecessary variable according to Shveta's suggestions [5].
> * Some other adjustments according to feedback from [4][5][6].

I noticed that Cfbot failed to compile the document due to a typo after renaming
the subscription option. Here are the updated V67 patches to fix that, only the doc
in 0001 is modified.

Best Regards,
Hou zj

Commits

Fix intermittent BF failures in 035_conflicts.
- 0f42206531b3 19 (unreleased) landed
Resume conflict-relevant data retention automatically.
- 0d48d393d465 19 (unreleased) landed
Fix intermittent test failure introduced in 6456c6e2c4.
- 01d793698f59 19 (unreleased) landed
Fix Coverity issue reported in commit a850be2fe.
- 5ac3c1ac22cb 19 (unreleased) landed
Add test to prevent premature removal of conflict-relevant data.
- 6456c6e2c4ad 19 (unreleased) landed
Post-commit review fixes for 228c370868.
- 1f7e9ba3ac4e 19 (unreleased) landed
Add max_retention_duration option to subscriptions.
- a850be2fe653 19 (unreleased) landed
Detect and report update_deleted conflicts.
- fd5a1a0c3e56 19 (unreleased) landed
Preserve conflict-relevant data during logical replication.
- 228c37086855 19 (unreleased) landed
Integrate FullTransactionIds deeper into two-phase code
- 62a17a92833d 19 (unreleased) cited
Improve checks for GUC recovery_target_timeline
- fd7d7b719137 19 (unreleased) cited
Prevent excessive delays before launching new logrep workers.
- fd519419c948 18.0 cited
Keep WAL segments by slot's last saved restart LSN
- ca307d5cec90 18.0 cited
Rework some code handling pg_subscription data in psql and pg_dump
- 08691ea958c2 18.0 cited
Use generateClonedIndexStmt to propagate CREATE INDEX to partitions.
- 68dfecbef210 18.0 cited