Horton
Menu

RE: [PATCH] Support automatic sequence replication

Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>

View thread
From: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
To: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>
Cc: Ajin Cherian <itsajin@gmail.com>, Ashutosh Sharma <ashu.coek88@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Amit Kapila <amit.kapila16@gmail.com>, shveta malik <shveta.malik@gmail.com>
Date: 2026-03-09T03:16:47Z
Lists: pgsql-hackers 
Dear Hou,

Thanks for uprating the patch. Few comments.

01.
The patch needs to be rebased, because of the missing inclusion of wait_event.h.
It might be affected by the commit 868825aae.

02. start_sequence_sync
Missing ProcessConfigFile() in the loop. Now it's done only in copy_sequences(),
but we can reach there when some sequences need to be synchronized.

03.
Can we describe needed privileges? IIUC, initial sync needs the UPDATE privilege,
additionally periodic synch needs SELECT privilege.

04.
```
+               long            sleep_ms = SEQSYNC_MIN_SLEEP_MS;
```

This is used in the for loop, make it the loop-specific variable.

Best regards,
Hayato Kuroda
FUJITSU LIMITED

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Don't include wait_event.h in pgstat.h

  2. Don't include proc.h in shm_mq.h

  3. Fix unsafe RTE_GROUP removal in simplify_EXISTS_query

  4. Add sequence synchronization for logical replication.