RE: [Proposal] Adding Log File Capability to pg_createsubscriber

Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>

From: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>

To: 'Amit Kapila' <amit.kapila16@gmail.com>, Gyan Sreejith <gyan.sreejith@gmail.com>

Cc: Shlok Kyal <shlok.kyal.oss@gmail.com>, vignesh C <vignesh21@gmail.com>, Euler Taveira <euler@eulerto.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, Peter Smith <smithpb2250@gmail.com>

Date: 2026-03-18T13:44:37Z

Lists: pgsql-hackers

Attachments

v11-0001-pg_createsubscriber-use-own-reporting-functions.patch (application/octet-stream) patch v11-0001
v11-0002-Add-a-new-argument-l-logdir-to-pg_createsubscrib.patch (application/octet-stream) patch v11-0002
v11-0003-Address-comments-from-Hayato-Kuroda.patch (application/octet-stream) patch v11-0003

Dear Amit,

> 
> This looks odd to me. I think it would be better to encapsulate this
> in one function (something like we have in pg_log_v) and then based on
> log level, do required handling.
>

Based on the suggestion, I updated patches. Please see attached series.

v11-0001 replaces existing pg_log_xxx families to new reporting function
pg_createsub_log(). Now only pg_fatal is overwritten, which is same as pg_uprade.

v11-0002 is the rebased version of v10. Nothing new, but codes are adjusted based
on 0001.

v11-0003 contains changes from me [1]. 0002 and 0003 can be combined if it's OK.

[1]: https://www.postgresql.org/message-id/OS9PR01MB12149C7DE09F13C3BCBD9357DF54EA%40OS9PR01MB12149.jpnprd01.prod.outlook.com

Best regards,
Hayato Kuroda
FUJITSU LIMITED

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

pg_createsubscriber: Don't use MAXPGPATH
- 99b726ac4894 19 (unreleased) landed
pg_createsubscriber: Remove separate logfile_open() function
- f5528b90b411 19 (unreleased) landed
pg_createsubscriber: Use logging.c log file callback
- 847336ba53af 19 (unreleased) landed
Add log file support to logging.c
- 41237556f8c5 19 (unreleased) landed
pg_createsubscriber: Add -l/--logdir option to redirect output to files.
- 6b5b7eae3ae6 19 (unreleased) landed
pg_createsubscriber: Introduce module-specific logging functions.
- d6628a5ea0a5 19 (unreleased) landed
Fix another buglet in archive_waldump.c.
- 69c57466a752 19 (unreleased) cited