Re: Teach pg_receivewal to use lz4 compression
gkokolatos@pm.me
From: gkokolatos@pm.me
To: Michael Paquier <michael@paquier.xyz>
Cc: Magnus Hagander <magnus@hagander.net>,
Dilip Kumar <dilipbalaut@gmail.com>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-07-02T07:35:00Z
Lists: pgsql-hackers
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Friday, July 2nd, 2021 at 03:10, Michael Paquier <michael@paquier.xyz> wrote: > On Thu, Jul 01, 2021 at 02:10:17PM +0000, gkokolatos@pm.me wrote: > > > Micheal suggested on the same thread to move my entry in the help output so that > > > > the output remains ordered. I would like the options for the compression method and > > > > the already existing compression level to next to each other if possible. Then it > > > > should be either 'X' or 'Y'. > > Hmm. Grouping these together makes sense for the user. One choice > > that we have here is to drop the short option, and just use a long > > one. What I think is important for the user when it comes to this > > option is the consistency of its naming across all the tools > > supporting it. pg_dump and pg_basebackup, where we could plug LZ4, > > already use most of the short options you could use for pg_receivewal, > > having only a long one gives a bit more flexibility. Good point. I am going with that one. > -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- > > Michael
Commits
-
Fix header inclusion order in pg_receivewal.c
- f512efb2d50a 15.0 landed
-
Remove useless LZ4 system call on failure when writing file header
- f79962d8264b 15.0 landed
-
Add support for LZ4 compression in pg_receivewal
- babbbb595d23 15.0 landed
-
Rework compression options of pg_receivewal
- d62bcc8b07f9 15.0 landed
-
Clarify some errors in pg_receivewal when closing WAL segments
- cddcf7842c31 15.0 landed