Horton

Thread

Commits

  1. #ifdef out some dead code in psql/mainloop.c.

  1. postgresql-10.0/src/bin/psql/mainloop.c:465: suspicious condition ?

    David Binderman <dcb314@hotmail.com> — 2017-10-06T07:21:33Z

    Hello there,

postgresql-10.0/src/bin/psql/mainloop.c:461] -> [postgresql-10.0/src/bin/psql/mainloop.c:465]: (warning) Opposite inner 'if' condition leads to a dead code block.

Source code is

    if (query_buf->len > 0 && !pset.cur_cmd_interactive &&
        successResult == EXIT_SUCCESS)
    {
        /* save query in history */
        if (pset.cur_cmd_interactive)
            pg_send_history(history_buf);

It looks like function pg_send_history can never be executed.

Regards

David Binderman

  2. Re: postgresql-10.0/src/bin/psql/mainloop.c:465: suspicious condition ?

    Tom Lane <tgl@sss.pgh.pa.us> — 2017-10-06T15:07:28Z

    David Binderman <dcb314@hotmail.com> writes:
> postgresql-10.0/src/bin/psql/mainloop.c:461] -> [postgresql-10.0/src/bin/psql/mainloop.c:465]: (warning) Opposite inner 'if' condition leads to a dead code block.

Huh ... that code's been like that since 2006.  Odd that nothing's
noticed the dead-ness before.  What tool were you using?

			regards, tom lane

  3. Re: postgresql-10.0/src/bin/psql/mainloop.c:465: suspicious condition ?

    David Binderman <dcb314@hotmail.com> — 2017-10-06T15:10:29Z

    Hello there,

>Huh ... that code's been like that since 2006.  Odd that nothing's
>noticed the dead-ness before.  What tool were you using?

cppcheck, available from sourceforge.

Regards

David Binderman

  4. Re: postgresql-10.0/src/bin/psql/mainloop.c:465: suspicious condition ?

    Tom Lane <tgl@sss.pgh.pa.us> — 2017-10-06T15:37:05Z

    David Binderman <dcb314@hotmail.com> writes:
>> Huh ... that code's been like that since 2006.  Odd that nothing's
>> noticed the dead-ness before.  What tool were you using?

> cppcheck, available from sourceforge.

Thanks.  I've corrected this in HEAD, but it seems not worth
back-patching since it's really just cosmetic.

			regards, tom lane