Re: [HACKERS] Optional message to user when terminating/cancelling backend

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>

To: Michael Paquier <michael@paquier.xyz>

Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Eren Başak <eren@citusdata.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Yugo Nagata <nagata@sraoss.co.jp>, Thomas Munro <thomas.munro@enterprisedb.com>, Michael Paquier <michael.paquier@gmail.com>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>

Date: 2018-04-06T09:18:34Z

Lists: pgsql-hackers

Attachments

0001-Refactor-backend-signalling-code-v10.patch (application/octet-stream) patch v10-0001
0002-Support-optional-message-in-backend-cancel-terminate-v10.patch (application/octet-stream) patch v10-0002

> On 06 Apr 2018, at 04:49, Michael Paquier <michael@paquier.xyz> wrote:
> 
> On Thu, Apr 05, 2018 at 11:33:57PM +0200, Daniel Gustafsson wrote:
>> It seemed like a good idea at the time to indicate which part was submitted by
>> the user, but looking at it now the colon sign is a pretty clear indicator
>> already.
> 
> Dropping the quotes is more consistent with other error messages.  We
> don't bother about quoting things for example with system-related errors
> generated by strerror().

Yep, I completely agree.  Attached are patches with the quotes removed and
rebased since Oids were taken etc.

cheers ./daniel

Commits

Refactor user-facing SQL functions signalling backends
- 09921f397b84 12.0 landed
Introduce 64-bit hash functions with a 64-bit seed.
- 81c5e46c490e 11.0 cited