Horton

Re: [Proposal] Global temporary tables

曾文旌 (义从) <wenjing.zwj@alibaba-inc.com>

View thread
From: 曾文旌 <wenjing.zwj@alibaba-inc.com>
To: Erik Rijkers <er@xs4all.nl>
Cc: Pavel Stehule <pavel.stehule@gmail.com>, Robert Haas <robertmhaas@gmail.com>, Prabhat Sahu <prabhat.sahu@enterprisedb.com>, tushar <tushar.ahuja@enterprisedb.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, Konstantin Knizhnik <k.knizhnik@postgrespro.ru>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, "蔡松露(子嘉)" <zijia@taobao.com>, "Cai, Le" <le.cai@alibaba-inc.com>, "萧少聪(铁庵)" <shaocong.xsc@alibaba-inc.com>
Date: 2020-04-09T13:28:25Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. PageAddItemExtended(): Add LP_UNUSED assertion.

  2. Remove temporary files after backend crash

  3. Fix comment in indexing.c

  4. Fix failure to ignore leftover temp tables after a server crash.

Attachments


> 2020年4月7日 下午6:40，Erik Rijkers <er@xs4all.nl> 写道：
> 
> On 2020-04-07 10:57, 曾文旌 wrote:
> 
>> [global_temporary_table_v24-pg13.patch ]
> 
> Hi,
> 
> With gcc 9.3.0 (debian stretch), I see some low-key protests during the build:
> 
> index.c: In function ‘index_drop’:
> index.c:2051:8: warning: variable ‘rel_persistence’ set but not used [-Wunused-but-set-variable]
> 2051 |  char  rel_persistence;
>      |        ^~~~~~~~~~~~~~~
> storage_gtt.c: In function ‘gtt_force_enable_index’:
> storage_gtt.c:1252:6: warning: unused variable ‘indexOid’ [-Wunused-variable]
> 1252 |  Oid indexOid = RelationGetRelid(index);
>      |      ^~~~~~~~
> cluster.c: In function ‘copy_table_data’:
> cluster.c:780:2: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
>  780 |  if (RELATION_IS_GLOBAL_TEMP(OldHeap));
>      |  ^~
> cluster.c:781:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
>  781 |   is_gtt = true;
>      |   ^~~~~~
> 

Part of the problem is that some variables are only used by assert statements, and I fixed those alarms.
Please provide your configue parameter, and I will verify it again.


Wenjing