Horton

Re: RecoveryInProgress() has critical side effects

Nathan Bossart <bossartn@amazon.com>

View thread View on postgr.es
From: "Bossart, Nathan" <bossartn@amazon.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Andres Freund <andres@anarazel.de>, amul sul <sulamul@gmail.com>
Date: 2021-11-15T22:09:17Z
Lists: pgsql-hackers 
On 11/15/21, 1:30 PM, "Robert Haas" <robertmhaas@gmail.com> wrote:
> Here's a new version that does it that way. Any other opinions?

LGTM

> The best thing I could come up with for a test case for this was to
> try repeatedly making a new connection and running "SELECT
> txid_current()", which will cause just one WAL record to be generated.
> Unfortunately that path has overhead from a lot of other causes so I'm
> not sure the results are very meaningful, but here they are:
>
> v1: 0.378 ms
> v2: 0.391 ms
> common base commit (10eae82b2): 0.376 ms

I'm personally not too worried about a ~4% regression in this
particular benchmark...

Nathan

Commits

  1. Remove InitXLOGAccess().

  2. Move InitXLogInsert() call from InitXLOGAccess() to BaseInit().