Horton

Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments

Chao Li <li.evan.chao@gmail.com>

View thread
From: Chao Li <li.evan.chao@gmail.com>
To: Aleksander Alekseev <aleksander@tigerdata.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Nathan Bossart <nathandbossart@gmail.com>, Arseniy Mukhin <arseniy.mukhin.dev@gmail.com>, Bruce Momjian <bruce@momjian.us>, Michael Paquier <michael@paquier.xyz>
Date: 2025-11-11T06:28:43Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. pgindent: improve formatting of multiline comments.

  2. Adjust style of some debugging macros.

  3. Fix a couple of comments.

  4. Add IGNORE NULLS/RESPECT NULLS option to Window functions.

  5. Split WaitEventSet functions to separate source file


> On Nov 10, 2025, at 17:28, Aleksander Alekseev <aleksander@tigerdata.com> wrote:
> 
>> 1. I just ran the patched pgindent against a random file, then I got a lot diffs like:
>> 
>> ```
>>        /*
>> -        * Direct advancement: avoid waking non-caught up backends that
>> -        * aren't interested in our notifications.
>> +        * Direct advancement: avoid waking non-caught up backends that aren't
>> +        * interested in our notifications.
>>         */
>> ```
> 
> I'm not sure if this is part of the PostgreSQL code base either. My
> best guess is that something is wrong with whitespaces here (tabs vs
> spaces). We have plenty of multiline comments like this and from what
> I can tell they are processed correctly.

I recalled that. I ran pgindent on a file from a patch I was reviewing, so, the file was not pgindent-ed yet at the time.

I just tried to run the patched pgindent on several files and no diff generated. So this comment is resolved.

Regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/