Re: bugfix - fix broken output in expanded aligned format, when data are too short
Chao Li <li.evan.chao@gmail.com>
From: Chao Li <li.evan.chao@gmail.com>
To: Pavel Stehule <pavel.stehule@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-03-24T06:12:18Z
Lists: pgsql-hackers
> On Mar 24, 2026, at 13:46, Pavel Stehule <pavel.stehule@gmail.com> wrote: > > Hi > > new version > > * fixed unwanted forcing to wrapped mode > * regress test > > Regards > > Pavel > <v20260324-1-0001-The-output-of-thin-table-is-broken-in-expanded-mode-.patch> Thanks for the fix. The patch overall looks good to me. A couple of small comments: 1 ``` /* * Calculate available width for data in wrapped mode */ - if (cont->opt->format == PRINT_WRAPPED) + if (cont->opt->format == PRINT_WRAPPED || cont->opt->format == PRINT_ALIGNED) ``` Since the condition has been updated, I think the comment above should be adjusted as well. 2 ``` +-- the output in expanded mode is shorter than header +\pset border 2 +\pset expanded on +create table psql_short_tab(a int, b int); +insert into psql_short_tab values(10,20),(30,40); +\pset format aligned +select * from psql_short_tab; +\pset format wrapped +select * from psql_short_tab; +drop table psql_short_tab; + ``` After this test, does it make sense to turn expanded mode off explicitly, in case it affects following tests? Today the next test happens to reset it, but maybe tomorrow a new test gets added before that point. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/
Commits
-
psql: Fix expanded aligned output
- a4ca91ea1891 14 (unreleased) landed
- 022ba5c61412 15 (unreleased) landed
- 1edbe669549f 16 (unreleased) landed
- efd885d05b8b 17 (unreleased) landed
- 07a6c262beee 18 (unreleased) landed
- 3d0d6741d810 19 (unreleased) landed