Horton

Re: Tab completion for large objects

Chao Li <li.evan.chao@gmail.com>

View thread
From: Chao Li <li.evan.chao@gmail.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>, Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>, pgsql-hackers@lists.postgresql.org
Date: 2025-10-23T09:22:18Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. psql: Improve tab completion for large objects.


> On Oct 23, 2025, at 15:22, Fujii Masao <masao.fujii@gmail.com> wrote:
> 
> On Sun, Jul 27, 2025 at 4:00 PM Fujii Masao <masao.fujii@gmail.com> wrote:
>> I think it's worth applying patch 0002 and part of 0001, so I've merged
>> those changes into a single patch. Patch attached. Any thoughts?
>> 
>> 
>> +               else if (TailMatches("LARGE"))
>> +                       COMPLETE_WITH("OBJECT");
>> 
>> It seems the "ALTER DEFAULT PRIVILEGES ... LARGE" case was missed
>> here. In that context, we should complete with "OBJECTS" instead of
>> "OBJECT". I've fixed that in the patch.
> 
> Attached is the rebased version of the patch.
> 
> Regards,
> 
> -- 
> Fujii Masao
> <v3-0001-psql-Improve-tab-completion-for-large-object.patch>

The code change is solid. One tidy comment on the commit subject and message:

```
Subject: [PATCH v3] psql: Improve tab completion for large object.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This commit enhances psql's tab completion support for a large object:
```

I think we can use “large objects” in the both places. Because completion can be “OBJECT” or “OBJECTS”. And a comment uses “objects”:

```
 	/*
 	 * Complete "GRANT/REVOKE * ON DATABASE/DOMAIN/..." with a list of
-	 * appropriate objects.
+	 * appropriate objects or keywords.
```

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/