Horton
Menu

Re: [PATCH] Add tests for Bitmapset

Greg Burd <greg@burd.me>

View thread
From: Greg Burd <greg@burd.me>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Nathan Bossart <nathandbossart@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>
Date: 2025-09-17T14:53:26Z
Lists: pgsql-hackers

Attachments

On Sep 17 2025, at 9:55 am, Robert Haas <robertmhaas@gmail.com> wrote:

> On Wed, Sep 17, 2025 at 9:18 AM Greg Burd <greg@burd.me> wrote:
>> > +static void
>> > +elog_bitmapset(int elevel, const char *label, const Bitmapset *bms)
>> >
>>  
>> I added a function bms_values() that prints out the values contained in
>> a bitmapset and changed a few tests to use it.  I removed the
>> elog_bitmapset() as it isn't being used and now that it's easy to output
>> the set in SQL why keep it for debugging?
>  
> How about using outBitmapset() which already exists?

Robert,

Thanks for chiming in, not sure how I missed that one. :)

> --  
> Robert Haas
> EDB: http://www.enterprisedb.com

I've updated the hash value for 32bit systems and changed the
bms_values() function to use outBitmapset() via bmsToString().

best.

-greg

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Minor fixes for test_bitmapset.c

  2. test_bitmapset: Improve random function

  3. Add mem_exceeded_count column to pg_stat_replication_slots.

  4. Tidy-up unneeded NULL parameter checks from SQL function

  5. Remove check for NULL in STRICT function

  6. Fixes for comments in test_bitmapset

  7. Minor fixups of test_bitmapset.c

  8. test_bitmapset: Simplify code of the module

  9. test_bitmapset: Expand more the test coverage

  10. Fix compiler warnings in test_bitmapset

  11. Add a test module for Bitmapset