Re: [PATCH] test/ssl: rework the sslfiles Makefile target

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jacob Champion <pchampion@vmware.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, "andrew@dunslane.net" <andrew@dunslane.net>
Date: 2021-07-28T21:09:57Z
Lists: pgsql-hackers
> On 28 Jul 2021, at 23:02, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Jacob Champion <pchampion@vmware.com> writes:

>> As long as the .SECONDARYEXPANSION magic is clear enough to others, I'm
>> happy.
> 
> After reading the gmake docs about that, I'd have to say it's likely to be next
> door to unmaintainable.


Personally, I don’t think it’s that bad, but mileage varies.  It’s obviously a
show-stopper if maintainers don’t feel comfortable with it.

> And, AFAICT, it's not in 3.80.

That however, is a very good point that I missed.  I think it’s a good tool,
but probably not enough to bump the requirement.

--
Daniel Gustafsson		https://vmware.com/




Commits

  1. Refactor the sslfiles Makefile target for ease of use

  2. Remove unused regression test certificate server-ss