Horton

Re: Synchronize with imath upstream

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: pgsql-hackers@lists.postgresql.org,Alvaro Herrera <alvherre@2ndquadrant.com>,David Fetter <david@fetter.org>
Cc: Andrew Gierth <andrew@tao11.riddles.org.uk>,Noah Misch <noah@leadboat.com>,pgsql-hackers@postgresql.org
Date: 2019-02-06T14:29:15Z
Lists: pgsql-hackers 

On February 6, 2019 5:17:50 AM GMT+05:30, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
>On 2019-Feb-03, David Fetter wrote:
>
>> On Sun, Feb 03, 2019 at 07:07:36AM +0000, Andrew Gierth wrote:
>> > >>>>> "Noah" == Noah Misch <noah@leadboat.com> writes:
>
>> > So far, expressed opinions have run about 4:2 in favour of allowing
>> > mixed declarations and code.
>> 
>> +1 for this.
>
>Just curious, why do you care?  If you want to use such constructs in
>extension code, you can add it in your makefiles.
>
>I'm -1 for this myself.  I think there are a few places that could
>benefit from it, but my fear is that many *more* places would get
>worse.

Because of imported code like ryu and imath? And because it can make code considerably better when used judiciously.

Andres
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Commits

  1. Import changes from IMath versions (1.3, 1.29].

  2. Cherry-pick security-relevant fixes from upstream imath library.