Re: Amcheck verification of GiST and GIN

Andrey Borodin <x4mmm@yandex-team.ru>

From: "Andrey M. Borodin" <x4mmm@yandex-team.ru>

To: Alexander Lakhin <exclusion@gmail.com>

Cc: Andrey Borodin <amborodin86@gmail.com>, Peter Geoghegan <pg@bowt.ie>, Mark Dilger <mark.dilger@enterprisedb.com>, Jose Arthur Benetasso Villanova <jose.arthur@gmail.com>, Andres Freund <andres@anarazel.de>, Nikolay Samokhvalov <samokhvalov@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2024-07-05T12:27:55Z

Lists: pgsql-hackers

Attachments

v27-0001-Refactor-amcheck-to-extract-common-locking-routi.patch (application/octet-stream) patch v27-0001
v27-0004-Add-GiST-support-to-pg_amcheck.patch (application/octet-stream) patch v27-0004
v27-0003-Add-gin_index_parent_check-to-verify-GIN-index.patch (application/octet-stream) patch v27-0003
v27-0002-Add-gist_index_check-function-to-verify-GiST-ind.patch (application/octet-stream) patch v27-0002

> On 6 Apr 2023, at 09:00, Alexander Lakhin <exclusion@gmail.com> wrote:
> 
> I've tried to use this feature with the latest patch set and discovered that
> modified pg_amcheck doesn't find any gist indexes when running without a
> schema specification.

Thanks, Alexander! I’ve fixed this problem and rebased on current HEAD.
There’s one more problem in pg_amcheck’s GiST verification. We must check that amcheck is 1.5+ and use GiST verification only in that case…

Best regards, Andrey Borodin.

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

amcheck: Fix posting tree checks in gin_index_check()
- 0cf205e122ae 18.0 landed
amcheck: Fix parent key check in gin_index_check()
- cdd1a431f21d 18.0 landed
amcheck: Fix checks of entry order for GIN indexes
- 0b54b392334b 18.0 landed
amcheck: Remove unused GinScanItem->parentlsn field
- 8dd41c0bff5b 18.0 landed
amcheck: Test gin_index_check on a multicolumn index
- c89d6b889ce9 18.0 landed
Remove incidental md5() function use from test
- 49b82522f13f 18.0 landed
amcheck: Add a GIN index to the CREATE INDEX CONCURRENTLY tests
- 68f97aeadb8e 18.0 landed
amcheck: Add a test with GIN index on JSONB data
- ca738bdc4c9d 18.0 landed
amcheck: Fix indentation in verify_gin.c
- ec4327d106be 18.0 landed
amcheck: Add gin_index_check() to verify GIN index
- 14ffaece0fb5 18.0 landed
amcheck: Move common routines into a separate module
- d70b17636ddf 18.0 landed
Fix grammar in GIN README
- fb9dff76635d 18.0 landed
Avoid amcheck inline compression false positives.
- eba775345d23 12.0 cited