Horton

Re: pipe_read_line for reading arbitrary strings

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-03-08T23:06:15Z
Lists: pgsql-hackers 
> On 8 Mar 2024, at 19:38, Daniel Gustafsson <daniel@yesql.se> wrote:
> 
>> On 8 Mar 2024, at 18:13, Peter Eisentraut <peter@eisentraut.org> wrote:
> 
>>> Good catch, that's an incorrect copy/paste, it should use ERRCODE_NO_DATA.
>> 
>> Also it shouldn't print %m, was my point.
> 
> Absolutely, I removed that in the patch upthread, it was clearly wrong.

Pushed the fix for the incorrect logline and errcode.

--
Daniel Gustafsson

Commits

  1. Fix errorhandling for reading from a pipe

  2. Refactor pipe_read_line to return the full line

  3. Add -c/--restore-target-wal to pg_rewind

  4. Here is a patch that fixes the pipes used in find_other_exec() when