Re: doc: Improve description of io_combine_limit and io_max_combine_limit GUCs
Chao Li <li.evan.chao@gmail.com>
From: Chao Li <li.evan.chao@gmail.com>
To: Karina Litskevich <litskevichkarina@gmail.com>
Cc: Fujii Masao <masao.fujii@gmail.com>,
Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-11-05T23:59:18Z
Lists: pgsql-hackers
> On Nov 5, 2025, at 21:58, Karina Litskevich <litskevichkarina@gmail.com> wrote: > > > > I'm attaching these changes as a separate patch just in case. You can > squash them if you like. Not sure what to do with the commitfest entry. > Should I change it back to Needs review? > > Best regards, > Karina Litskevich > Postgres Professional: http://postgrespro.com/ > <v2-0002-doc-Fix-description-of-GUCs-with-PGC_POSTMASTER-c.patch><v2-0001-doc-Improve-description-of-io_combine_limit-and-i.patch> ``` - This parameter can only be set in the <filename>postgresql.conf</filename> - file or on the server command line. + This parameter can only be set at server start. ``` I think this change will lose information. Actually, I think that even the original message is not accurate enough. For PGC_POSTMASTER parameters, there are 3 ways to update their values: * Editing postgres.conf * server command line * ALTER SYSTEM, updating postgres.auto.conf But all require a server restart. The original doc misses “ALTER SYSTEM”, and your change just hides all methods. So I would suggest: ``` This parameter can only be set at server start (for example, in postgresql.conf, via ALTER SYSTEM, or on the server command line). ``` Fujii-san, what do you think? Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/
Commits
-
doc: Fix descriptions of some PGC_POSTMASTER parameters.
- 2dfda09ad77b 13.23 landed
- 9326cf9ce997 14.20 landed
- a2e17a2bb200 15.15 landed
- 9a882a5dbfe6 16.11 landed
- 17bf6f1098b5 17.7 landed
- ac72a905d068 18.1 landed
- c32e32f763b4 19 (unreleased) landed
-
doc: Clarify units for io_combine_limit and io_max_combine_limit.
- b841c91c7b55 17.7 landed
- d83da466b59b 18.1 landed
- 6fba6cb05ddf 19 (unreleased) landed