Re: Option to dump foreign data in pg_dump
Daniel Gustafsson <daniel@yesql.se>
From: Daniel Gustafsson <daniel@yesql.se>
To: Luis Carril <luis.carril@swarm64.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
Tom Lane <tgl@sss.pgh.pa.us>
Date: 2019-07-01T09:29:54Z
Lists: pgsql-hackers
> On 28 Jun 2019, at 17:30, Tom Lane <tgl@sss.pgh.pa.us> wrote: > > Yeah, I think the feature as-proposed is a shotgun that's much more likely > > to cause problems than solve them. Almost certainly, what people would > > really need is the ability to dump individual foreign tables' data not > > everything. (I also note that the main reason for "dump everything", > > namely to get a guaranteed-consistent snapshot, isn't really valid for > > foreign tables anyhow.) I think this is sort of key here, the consistency guarantees are wildly different. A note about this should perhaps be added to the docs for the option discussed here? > On 28 Jun 2019, at 19:55, Luis Carril <luis.carril@swarm64.com> wrote: > What about providing a list of FDW servers instead of an all or nothing option? In that way the user really has to do a conscious decision to dump the content of the foreign tables for a specific server, this would allow distinction if multiple FDW are being used in the same DB. I think this is a good option, the normal exclusion rules can then still apply in case not everything from a specific server is of interest. cheers ./daniel
Commits
-
pg_dump: Allow dumping data of specific foreign servers
- 2f9eb3132094 13.0 landed