Re: [PATCH] Add tests for Bitmapset

Greg Burd <greg@burd.me>

From: Greg Burd <greg@burd.me>

To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Cc: Nathan Bossart <nathandbossart@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Michael Paquier <michael@paquier.xyz>

Date: 2025-09-15T18:00:18Z

Lists: pgsql-hackers

Attachments

v2-0001-Add-a-module-that-tests-Bitmapset.patch (application/octet-stream) patch v2-0001

On Sep 13 2025, at 10:23 am, Greg Burd <greg@burd.me> wrote:
>  
> Sawada-san, Michael,
>  
> Thank you both for the push to measure.  Before the patch as it stands
> now the
> coverage for src/backend/nodes/bitmapset.c is 63.5% and after it is
> 66.5%.  Not
> an amazing difference, but something.  I guess I expected this to be
> higher given
> the degree to which this datatype is used.
>  
> I'll review the gaps in coverage and update the tests.  I'll look for
> a way to add meaningful randomization.
>  
> -greg

Hello hackers,

Here's the progress I've made in coverage for testing Bitmapset.

coverage:      HEAD        v1        v2
  lines......: 87.1        87.7      91.3
  functions..: 100         100       100
  branches...: 63.5        66.5      77.9

I've also added a function that performs a variety of operations using
random data.

For reference radixtree has:

coverage:      HEAD
  lines......: 98.3  
  functions..: 97.2
  branches...: 89.4

best,

-greg

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Minor fixes for test_bitmapset.c
- 5142f0093e64 19 (unreleased) landed
test_bitmapset: Improve random function
- 9d46b86529e8 19 (unreleased) landed
Add mem_exceeded_count column to pg_stat_replication_slots.
- d3b6183dd988 19 (unreleased) landed
Tidy-up unneeded NULL parameter checks from SQL function
- a69b55cd4727 19 (unreleased) landed
Remove check for NULL in STRICT function
- 381f5cffae00 19 (unreleased) landed
Fixes for comments in test_bitmapset
- a1b064e4b226 19 (unreleased) landed
Minor fixups of test_bitmapset.c
- 3a6615806859 19 (unreleased) landed
test_bitmapset: Simplify code of the module
- 9952f6c05a40 19 (unreleased) landed
test_bitmapset: Expand more the test coverage
- 5668fff3c512 19 (unreleased) landed
Fix compiler warnings in test_bitmapset
- f83fe65f3fc1 19 (unreleased) landed
Add a test module for Bitmapset
- 00c3d87a5cab 19 (unreleased) landed