Horton
Menu

Re: Use correct macro for accessing offset numbers.

Roman Khapov <rkhapov@yandex-team.ru>

View thread
From: Roman Khapov <rkhapov@yandex-team.ru>
To: Kirill Reshke <reshkekirill@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2026-01-11T11:41:19Z
Lists: pgsql-hackers 
> On 11 Jan 2026, at 16:21, Kirill Reshke <reshkekirill@gmail.com> wrote:
> 
> Hi hackers!
> 
> PFA trivial patch that uses UInt16GetDatum for OffsetNumber rather
> than Int16GetDatum

Hi!

LGTM, should we check another places of offset number conversations to Datum
as part of this thread?

--
Best regards,
Roman Khapov

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Adjust some incorrect *GetDatum() macros

  2. Use more consistent *GetDatum() macros for some unsigned numbers