Thread

Commits

  1. doc: pg_buffercache documentation wordsmithing

  1. Fix inconsistency in the pg_buffercache documentation

    Bertrand Drouvot <bertranddrouvot.pg@gmail.com> — 2025-07-02T06:23:29Z

    Hi hackers,
    
    While working on [1], I noticed an inconsistency in the pg_buffercache
    documentation: ba2a3c2302f1 missed to add "the" before the pg_buffercache_numa()
    function introduction.
    
    PFA a tiny patch to add it for consistency purpose. Should be back-patched to
    18 where pg_buffercache_numa() has been introduced.
    
    [1]: https://www.postgresql.org/message-id/flat/Z/fFA2heH6lpSLlt%40ip-10-97-1-34.eu-west-3.compute.internal
    
    Regards,
    
    -- 
    Bertrand Drouvot
    PostgreSQL Contributors Team
    RDS Open Source Databases
    Amazon Web Services: https://aws.amazon.com
    
  2. Re: Fix inconsistency in the pg_buffercache documentation

    Daniel Gustafsson <daniel@yesql.se> — 2025-07-02T07:55:52Z

    > On 2 Jul 2025, at 08:23, Bertrand Drouvot <bertranddrouvot.pg@gmail.com> wrote:
    > 
    > Hi hackers,
    > 
    > While working on [1], I noticed an inconsistency in the pg_buffercache
    > documentation: ba2a3c2302f1 missed to add "the" before the pg_buffercache_numa()
    > function introduction.
    
    Thanks, that does indeed look like an omission.  There seems to be a few more
    on the same page however, how about the attached?
    
    --
    Daniel Gustafsson
    
    
  3. Re: Fix inconsistency in the pg_buffercache documentation

    Bertrand Drouvot <bertranddrouvot.pg@gmail.com> — 2025-07-02T08:06:34Z

    Hi,
    
    On Wed, Jul 02, 2025 at 09:55:52AM +0200, Daniel Gustafsson wrote:
    > > On 2 Jul 2025, at 08:23, Bertrand Drouvot <bertranddrouvot.pg@gmail.com> wrote:
    > > 
    > > Hi hackers,
    > > 
    > > While working on [1], I noticed an inconsistency in the pg_buffercache
    > > documentation: ba2a3c2302f1 missed to add "the" before the pg_buffercache_numa()
    > > function introduction.
    > 
    > Thanks, that does indeed look like an omission.
    
    Thanks for looking at it!
    
    > There seems to be a few more
    > on the same page however,
    
    Indeed, there is multiple kind of inconsistency that are worth to fix.
    
    > how about the attached?
    
    LGTM.
    
    Regards,
    
    -- 
    Bertrand Drouvot
    PostgreSQL Contributors Team
    RDS Open Source Databases
    Amazon Web Services: https://aws.amazon.com
    
    
    
    
  4. Re: Fix inconsistency in the pg_buffercache documentation

    Daniel Gustafsson <daniel@yesql.se> — 2025-07-02T09:52:09Z

    > On 2 Jul 2025, at 10:06, Bertrand Drouvot <bertranddrouvot.pg@gmail.com> wrote:
    > On Wed, Jul 02, 2025 at 09:55:52AM +0200, Daniel Gustafsson wrote:
    
    >> how about the attached?
    > 
    > LGTM.
    
    Thanks, committed.
    
    --
    Daniel Gustafsson