Re: Bug in MultiXact replay compat logic for older minor version after crash-recovery
x4mmm@yandex-team.ru
From: Andrey Borodin <x4mmm@yandex-team.ru>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: "段坤仁(刻韧)" <duankunren.dkr@alibaba-inc.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2026-03-20T11:55:52Z
Lists: pgsql-hackers
> On 19 Mar 2026, at 23:11, Heikki Linnakangas <hlinnaka@iki.fi> wrote: > > :-(. This is a gift that keeps giving. Well, maybe, we could leaving that deadlock in place for some time... > Idea 3: > > I think a better fix is to accept that our tracking is a little imprecise and use SimpleLruDoesPhysicalPageExist() to check if the page exists. I suspect that's too expensive to do on every RecordNewMultiXact() call that crosses a page, but perhaps we could do it once at StartupMultiXact(). > > Or perhaps track last-zeroed page separately from latest_page_number, and if we haven't seen any XLOG_MULTIXACT_ZERO_OFF_PAGE records yet after startup, call SimpleLruDoesPhysicalPageExist() to determine if initialization is needed. Attached patch does that. SimpleLruDoesPhysicalPageExist() does not detect recently zeroed pages via buffers, because it goes directly to FS. I tried this approach when implementing deadlock fix, it did not work for me. Best regards, Andrey Borodin.
Commits
-
Fix multixact backwards-compatibility with CHECKPOINT race condition
- e35e466f61b3 14.23 landed
- a5f412107f98 15.18 landed
- 77dff5d937b1 16.14 landed
- 1ca38503219a 17.10 landed
- 0852643e1c60 18.4 landed
-
Don't reset 'latest_page_number' when replaying multixid truncation
- 516310ed4dba 19 (unreleased) cited