Re: New gist vacuum.

x4mmm@yandex-team.ru

From: Andrey Borodin <x4mmm@yandex-team.ru>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Костя Кузнецов <chapaev28@ya.ru>, Jeff Janes <jeff.janes@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2017-11-12T18:20:24Z
Lists: pgsql-hackers

Attachments

Hello!

> 31 янв. 2016 г., в 17:18, Alvaro Herrera <alvherre@2ndquadrant.com> написал(а):
> 
> Костя Кузнецов wrote:
>> <div>Thank you, Jeff.</div><div>I reworking patch now. All // warning will be deleted.</div><div>About memory consumption new version will control size of stack and will operate with map of little size because i want delete old style vacuum(now if maintenance_work_mem less than needed to build info map we use old-style vacuum with logical order).</div>
> 
> You never got around to submitting the updated version of this patch,
> and it's been a long time now, so I'm marking it as returned with
> feedback for now.  Please do submit a new version once you have it,
> since this seems to be very useful.

I've rebased patch (see attachment), it seems to work. It still requires a bit of styling, docs and tests, at least.
Also, I thinks that hash table is not very good option if we have all pages there: we should either use array or do not fill table for every page.

If author and community do not object, I want to continue work on Konstantin's patch.

Best regards, Andrey Borodin.

Commits

  1. Make gistvacuumcleanup() count the actual number of index tuples.