Horton

Re: SSL Tests for sslinfo extension

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>, Andrew Dunstan <andrew@dunslane.net>, Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-11-29T23:16:57Z
Lists: pgsql-hackers 
> On 29 Nov 2021, at 23:50, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> 
> Daniel Gustafsson <daniel@yesql.se> writes:
>> Agreed.  The attached v3 covers the issuer and extension function to at least
>> some degree.  In order to reliably test the extension I added a new cert with a
>> CA extension.
> 
> I have two remaining trivial nitpicks, for which I attach an 0004
> delta patch: the README change was fat-fingered slightly, and some
> of the commentary about the key file seems now obsolete.

Ah yes, thanks.

> Otherwise I think it's good to go, so I marked it RFC.

Great!  I'll take another look over it tomorrow and will go ahead with it then.

--
Daniel Gustafsson		https://vmware.com/

Commits

  1. Use test-specific temp path for keys during SSL test

  2. Add TAP tests for contrib/sslinfo

  3. Extend configure_test_server_for_ssl to add extensions