Re: New developer papercut - Makefile references INSTALL
Daniel Gustafsson <daniel@yesql.se>
From: Daniel Gustafsson <daniel@yesql.se>
To: Tim McNamara <tim@mcnamara.nz>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-01-17T10:17:05Z
Lists: pgsql-hackers
Attachments
- install.diff (application/octet-stream) patch
> On 17 Jan 2022, at 02:11, Tim McNamara <tim@mcnamara.nz> wrote: > > Hello, > > I encountered a minor road bump when checking out the pg source today. The Makefile's all target includes the following help message if GNUmakefile isn't available: > > echo "You need to run the 'configure' program first. See the file"; \ > echo "'INSTALL' for installation instructions." ; \ > > After consulting README.git, it looks as though INSTALL isn't created unless the source is bundled into a release or snapshot tarball. I'm happy to submit a patch to update the wording, but wanted to check on the preferred approach. > > Perhaps this would be sufficient? > > echo "You need to run the 'configure' program first. See the file"; \ > echo "'INSTALL' for installation instructions, or visit" ; \ > echo "<https://www.postgresql.org/docs/devel/installation.html>" ; \ That's a good point, and one few developers are likely to spot so thanks for raising the issue. To avoid replicating the wording we can do something like the attached as well. -- Daniel Gustafsson https://vmware.com/
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Dynamically find correct installation docs in Makefile.
- c330b75d9cce 15.0 landed