Re: ACL_MAINTAIN, Lack of comment content
Daniel Gustafsson <daniel@yesql.se>
From: Daniel Gustafsson <daniel@yesql.se>
To: btsugieyuusuke <btsugieyuusuke@oss.nttdata.com>
Cc: Pgsql Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-09-30T09:40:29Z
Lists: pgsql-hackers
Attachments
- acl_maintain_comment.diff (application/octet-stream) patch
> On 30 Sep 2024, at 10:29, btsugieyuusuke <btsugieyuusuke@oss.nttdata.com> wrote: > > Hi hackers, > I found a flaw in the ACL_MAINTAIN comment. > > Commands such as VACUUM are listed as commands that are allowed to be executed by the MAINTAIN privilege. > However, LOCK TABLE is missing from the comment. > >> /* >> * Check if ACL_MAINTAIN is being checked and, if so, and not already set >> * as part of the result, then check if the user is a member of the >> * pg_maintain role, which allows VACUUM, ANALYZE, CLUSTER, REFRESH >> * MATERIALIZED VIEW, and REINDEX on all relations. >> */ > > Therefore, shouldn't LOCK TABLE be added to the comment? That's correct, for the list to be complete LOCK TABLE should be added as per the attached. -- Daniel Gustafsson
Commits
-
Add missing command for pg_maintain in comment
- 102de3be7334 18.0 landed