Horton

Re: Backporting BackgroundPsql

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, Heikki Linnakangas <hlinnaka@iki.fi>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Andrew Dunstan <andrew@dunslane.net>, Melanie Plageman <melanieplageman@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, Mikael Kjellström <mikael.kjellstrom@gmail.com>
Date: 2024-06-25T21:10:14Z
Lists: pgsql-hackers 
> On 25 Jun 2024, at 22:57, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> 
> Daniel Gustafsson <daniel@yesql.se> writes:
>> Before pulling any triggers I think https://commitfest.postgresql.org/48/4959/
>> should be considered, since Tom found some flaws in the current code around how
>> timers and timeouts are used.
> 
> That's certainly another issue to consider, but is it really a blocker
> for this one?

It's not a blocker, but when poking at the code it seems useful to consider the
open items around it.

>> However, since Andrew is actively aiming to replace all of this shortly, should
>> we wait a see where that lands to avoid having to backport another library
>> change?
> 
> I would like to see what he comes up with ... but is it likely to
> be something we'd risk back-patching?

Maybe it'll be a stretch given that it's likely to introduce new dependencies.

--
Daniel Gustafsson

Commits

  1. Fix missing installation/uninstallation rules for BackgroundPsql.pm

  2. Backport BackgroundPsql perl test module

  3. Add missing uninstallation rule for BackgroundPsql.pm

  4. Fix missing installation rules for BackgroundPsql.pm

  5. Skip \password TAP test on old IPC::Run versions

  6. Test SCRAM iteration changes with psql \password

  7. Refactor background psql TAP functions