Re: Extending amcheck to check toast size and compression

Mark Dilger <mark.dilger@enterprisedb.com>

From: Mark Dilger <mark.dilger@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>, Greg Stark <stark@mit.edu>, Heikki Linnakangas <hlinnaka@iki.fi>, Aleksander Alekseev <aleksander@timescale.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-11-06T08:04:48Z
Lists: pgsql-hackers

> On Nov 5, 2021, at 8:56 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> 
> Some of the buildfarm is unimpressed with this --- looks like the test
> output is less stable than you thought.

Yes, it does.  I had to play with it a bit to be sure the test itself is faulty, and I believe that it is.

—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company






Commits

  1. Remove tests added by bd807be6935929bdefe74d1258ca08048f0aafa3.

  2. amcheck: Add additional TOAST pointer checks.